break-lock does not accept upper-case 'Y' as 'yes'
Bug #335182 reported by
Jonathan Lange
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Low
|
Martin Pool |
Bug Description
Steps:
1. Lock a branch (e.g. Branch.
2. Run bzr break-lock on that branch
3. Press 'Y' (must be capital Y) when asked if you want to break the lock.
Expected: Bazaar interprets the keypress as "Yes, I really do want to break the lock"
Observed: Bazaar interprets the keypress as a mistake.
It's possible that bug 217134 is actually a manifestation of this.
Related branches
lp:~mbp/bzr/integration-old
- John A Meinel: Approve
- Diff: 257 lines
Changed in bzr: | |
importance: | Undecided → Low |
status: | New → Triaged |
tags: | added: easy lock |
Changed in bzr: | |
milestone: | none → 1.17 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
It looks like all that is necessary to fix this is to lowercase the user input before comparing.
I've attached a patch that fixes this for me with bzr 1.16.1. With the change it works for variations like Y as well as Yes, YES, and YeS.
It might be desirable to add uppercase Yes and No to the tests of the get_boolean function in tests/test_ui.py.