Traceback when uploading to an invalid location

Bug #278673 reported by Edward K. Ream
12
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Andrew Bennetts
Launchpad itself
Invalid
Undecided
Unassigned

Bug Description

Trying to create a new branch:

C:\leo.repo\trunk>bzr push bzr+ssh://<email address hidden>/~edreamleo/leo-editor-team/leo-editor/qtGui
Connected (version 2.0, client Twisted)
Authentication (publickey) successful!
Secsh channel 1 opened.
bzr: ERROR: bzrlib.errors.ErrorFromSmartServer: Error received from smart server: ('error', 'Permission denied: "Cannot create \'qtGui\'. On
ly Bazaar branches are allowed."')

Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 857, in run_bzr_catch_errors
  File "bzrlib\commands.pyo", line 797, in run_bzr
  File "bzrlib\commands.pyo", line 499, in run_argv_aliases
  File "bzrlib\builtins.pyo", line 802, in run
  File "bzrlib\push.pyo", line 47, in _show_push_branch
  File "bzrlib\bzrdir.pyo", line 798, in open_from_transport
  File "bzrlib\bzrdir.pyo", line 1725, in open
  File "bzrlib\bzrdir.pyo", line 2605, in _open
  File "bzrlib\remote.pyo", line 76, in __init__
  File "bzrlib\smart\client.pyo", line 111, in call
  File "bzrlib\smart\client.pyo", line 124, in call_expecting_body
  File "bzrlib\smart\client.pyo", line 72, in _call_and_read_response
  File "bzrlib\smart\message.pyo", line 265, in read_response_tuple
  File "bzrlib\smart\message.pyo", line 316, in _translate_error
ErrorFromSmartServer: Error received from smart server: ('error', 'Permission denied: "Cannot create \'qtGui\'. Only Bazaar branches are all
owed."')

bzr 1.6.1 on python 2.5.2 (win32)
arguments: ['bzr', 'push', 'bzr+ssh://<email address hidden>/~edreamleo/leo-editor-team/leo-editor/qtGui']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [1.6.0]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [unknown]
  qbzr C:\Program Files\Bazaar\plugins\qbzr [0.9.3]
  svn C:\Program Files\Bazaar\plugins\svn [0.4.11]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

C:\leo.repo\trunk>

Tags: hpss lp-code
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

You can't push to a subdirectory on launchpad, only to a branch itself, e.g. bzr+ssh://<email address hidden>/~edreamleo/leo-editor-team/leo-editor

Martin Albisetti (beuno)
Changed in launchpad-bazaar:
status: New → Invalid
Revision history for this message
Edward K. Ream (edreamleo) wrote : Re: [Bug 278673] Re: Crashing trying to create a branch

On Sun, Oct 5, 2008 at 12:02 PM, Martin Albisetti <email address hidden> wrote:
> ** Changed in: launchpad-bazaar
> Status: New => Invalid

Sorry, but this can not be invalid. Bzr should not give this message
on a user error.

Edward

Revision history for this message
Martin Albisetti (beuno) wrote : Re: Crashing trying to create a branch

Sure, bzr should handle this better.

Changed in launchpad-bazaar:
status: Invalid → Triaged
status: New → Triaged
Revision history for this message
Edward K. Ream (edreamleo) wrote : Re: [Bug 278673] Re: Crashing trying to create a branch

On Sun, Oct 5, 2008 at 2:29 PM, Martin Albisetti <email address hidden> wrote:
> Sure, bzr should handle this better.
>
> ** Changed in: bzr
> Product: Launchpad Bazaar Integration => Bazaar
> Status: Invalid => Triaged

Thanks.

Edward

Revision history for this message
Andrew Bennetts (spiv) wrote :

The "self._client.call('BzrDir.open', path)" line in RemoteBzrDir.__init__ needs a try/except that catches and translates ErrorFromSmartServer, like other smart client calls in that file.

Changed in bzr:
assignee: nobody → spiv
importance: Undecided → High
status: Triaged → Confirmed
Revision history for this message
Jonathan Lange (jml) wrote :

Why not change 'call' to do the translation?

Revision history for this message
Andrew Bennetts (spiv) wrote :

Yes, that's probably the logical next step, the main wrinkle is providing context for the error translation. Perhaps a self._call helper on the Remote* objects is the simplest way.

Revision history for this message
Andrew Bennetts (spiv) wrote :
Changed in bzr:
milestone: none → 1.9rc1
status: Confirmed → Fix Committed
Revision history for this message
Andrew Bennetts (spiv) wrote :

Fix landed in bzr.dev r3807.

Changed in bzr:
status: Fix Committed → Fix Released
Revision history for this message
Jonathan Lange (jml) wrote :

This was a bug in Bazaar itself, which is now fixed.

Changed in launchpad-bazaar:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.