hooks documentation doesn't clearly state which hooks can modify or abort the operation
Bug #247847 reported by
James Westby
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
Low
|
Unassigned | ||
Bug Description
Hi,
The documentation for hooks isn't explicit for every hook about
what effect it can have on the operation being performed.
It's pretty clear that post_* can't do much, and start_commit
states that it can modify the tree, but I think it would be useful
to state what is possible, and how to achieve it. For instance,
I can presumably abort the commit from a pre_commit hook,
but is this done by raising and error, or returning a certain
value, or both?
Thanks,
James
| Changed in bzr: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| Changed in bzr: | |
| status: | Triaged → Confirmed |
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 247847] Re: hooks documentation doesn't clearly state which hooks can modify or abort the operation | #1 |
| tags: | added: check-for-breezy |
To post a comment you must log in.
Dear James: please feel free to mark bugs confirmed and to set a
severity when filing them. We can always change it if we disagree.
Dear Jelmer: We don't use normally triaged (which really means
"accepted") in Bazaar, just "confirmed" means "someone has read it and
it's not invalid or incomplete."
Thanks,
--
Martin <http://