Bazaar

ValueError: I/O operation on closed file on Launchpad

Bug #236380 reported by Martin Albisetti
4
Affects Status Importance Assigned to Milestone
Bazaar
Invalid
Undecided
Unassigned
Launchpad itself
Fix Released
Critical
Jonathan Lange

Bug Description

Quite a few users have been having this problem in the past few days with Launchpad branches:

beuno@beuno-laptop:~$ bzr branch bzr+ssh://<email address hidden>/~planet-ubuntu/config/main planet
Server does not understand Bazaar network protocol 3, reconnecting. (Upgrade the server to avoid this.)
/srv/bazaar.launchpad.net/production/launchpad/sourcecode/bzr/bzrlib/lockable_files.py:110: UserWarning: file group LockableFiles(<canonical.codehosting.transport.LaunchpadTransport url=lp--1228886196:///~planet-ubuntu/config/main/.bzr/repository>) was not explicitly unlocked
  warn("file group %r was not explicitly unlocked" % self)
Traceback (most recent call last):
  File "/srv/bazaar.launchpad.net/production/launchpad/sourcecode/bzr/bzr", line 119, in ?
    sys.stdout.flush()
ValueError: I/O operation on closed file

.bzr.log output attached

Tags: lp-code
Revision history for this message
Martin Albisetti (beuno) wrote :
Tim Penhey (thumper)
Changed in launchpad-bazaar:
assignee: nobody → jml
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Jonathan Lange (jml) wrote :

Looks like we'll need to cherrypick the latest Bazaar in after all.

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 236380] Re: ValueError: I/O operation on closed file on Launchpad

On Sunday 01 June 2008 14:48:27 Jonathan Lange wrote:
> Looks like we'll need to cherrypick the latest Bazaar in after all.

Can you confirm that this will go away with bzr 1.5?

Can you give a bit more reason as to why this is happening?

Revision history for this message
Jonathan Lange (jml) wrote :

I can, but not today :)

The reason I said it was this part of the error message: "Server does not understand Bazaar network protocol 3, reconnecting. (Upgrade the server to avoid this.)"

Revision history for this message
Jonathan Lange (jml) wrote :

This is deeper than Bazaar version. Our best guess now is that it's a bug in the URL escaping logic which was changed recently.

Upgrading to critical.

Changed in launchpad-bazaar:
importance: High → Critical
Revision history for this message
Andrew Bennetts (spiv) wrote :

(The server drops the connection, and the client then gets stuck in an infinite busy-loop rather than realising the connection is gone. I've just sent a fix for that to the list, but obviously that's not the main bug here.)

Revision history for this message
Martin Pool (mbp) wrote :

Probably not a problem in bzr itself.

Changed in bzr:
status: New → Invalid
Revision history for this message
Jonathan Lange (jml) wrote :

This bug has been fixed in production. Still waiting on the fix to go into trunk.

Changed in launchpad-bazaar:
status: Confirmed → In Progress
Revision history for this message
Jonathan Lange (jml) wrote :

Fix landed in r6407.

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Jonathan Lange (jml)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.