"bzr branch http://bazaar.launchpad.net/...." fails with bzr.dev >= r3309

Bug #207558 reported by Andrew Bennetts
16
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Critical
Andrew Bennetts
Launchpad itself
Fix Released
Critical
Unassigned

Bug Description

bzr.dev revision 3309 introduced a change that would make it automatically probe for and attempt to use a smart server with any HTTP transport.

Unfortunately, the _SmartClient.remote_path_for_transport gives incorrect results with "http://" URLs (it handles "bzr+http://" just fine).

Also, because the fix for bug 124089 hasn't landed and been deployed on Launchpad yet, fixing the client still isn't enough to make this worth with bazaar.launchpad.net.

We should:
 * fix the bug in _SmartClient.remote_path_for_transport. I have a branch that does this, I'll associate it with this bug.
 * land the fix to bug 124089
 * probably explicitly disable the HTTP smart auto-probing in the client for a release, to give existing broken smart server deployments a chance to deploy a fixed bzr server. We can probably turn this feature on in 1.5.

Tags: lp-code

Related branches

Revision history for this message
Andrew Bennetts (spiv) wrote :

Assigning to me; I'm working on this.

Changed in bzr:
assignee: nobody → spiv
importance: Undecided → Critical
milestone: none → 1.4
status: New → In Progress
Revision history for this message
Andrew Bennetts (spiv) wrote :

The branch is <https://code.launchpad.net/~spiv/bzr/smart-http-fix>. I cannot associate it properly at the moment due to a TimeoutError from Launchpad.

Revision history for this message
Andrew Bennetts (spiv) wrote :

> We should:
> * fix the bug in _SmartClient.remote_path_for_transport. I have a
> branch that does this, I'll associate it with this bug.

I've submitted this to the list for review.

> * land the fix to bug 124089

This has now landed.

> * probably explicitly disable the HTTP smart auto-probing in the
> client for a release, to give existing broken smart server deployments
> a chance to deploy a fixed bzr server. We can probably turn this
> feature on in 1.5.

At Robert's suggestion, I've submitted a patch that does something a bit different: the auto-probing by default stays, and a "nosmart+" transport decorator is added. So you could do "bzr branch nosmart+http://host/..." to work around a misconfigured HTTP smart server.

Revision history for this message
Robert Collins (lifeless) wrote :

lp needs to deploy the fixed http backend, or disable the POST hook in apache. This isn't a regression as such - its clearly been broken for plain 'bzr+http' too for some time.

Changed in launchpad-bazaar:
importance: Undecided → Critical
Revision history for this message
Robert Collins (lifeless) wrote :

Symptoms on b.l.n:
robertc@lifeless-64:~/.bazaar/plugins/gtk$ bzr pull lp:bzr-gtk
You have not informed bzr of your launchpad login. If you are attempting a write operation it may fail. If it does, run "bzr launchpad-login YOUR_ID" to set your login and try again.
http://bazaar.launchpad.net/%7Ebzr-gtk/bzr-gtk/trunk is redirected to http://bazaar.launchpad.net/~bzr-gtk/bzr-gtk/trunk/
You have not informed bzr of your launchpad login. If you are attempting a write operation it may fail. If it does, run "bzr launchpad-login YOUR_ID" to set your login and try again.
bzr: ERROR: Not a branch: "http://bazaar.launchpad.net/~bzr-gtk/bzr-gtk/trunk/".
robertc@lifeless-64:~/.bazaar/plugins/gtk$ bzr pull http://bazaar.launchpad.net/~bzr-gtk/bzr-gtk/trunk/
http://bazaar.launchpad.net/%7Ebzr-gtk/bzr-gtk/trunk is redirected to http://bazaar.launchpad.net/~bzr-gtk/bzr-gtk/trunk/
bzr: ERROR: Not a branch: "http://bazaar.launchpad.net/~bzr-gtk/bzr-gtk/trunk/".

Revision history for this message
Jonathan Lange (jml) wrote :

What is the "fixed http backend"? Is it in bzr.dev already?

Revision history for this message
Andrew Bennetts (spiv) wrote :

I believe the bzr side of this is now fixed (and has been for a few days).

There's a separate "affects" line on this bug for tracking the problem with the bzr+http server on bazaar.launchpad.net.

Changed in bzr:
status: In Progress → Fix Released
Revision history for this message
Andrew Bennetts (spiv) wrote :

(For people tracking bzr.dev, a workaround is to use "bzr+ssh://" (if you have a launchpad account with SSH keys) or "nosmart+http://" instead of "http://".)

Revision history for this message
Robert Collins (lifeless) wrote :

RT filed to disabled the post handler. Next step is to get a working bzr deployed and tested on staging, then look at reenabling it in production.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 207558] Re: "bzr branch http://bazaar.launchpad.net/...." fails with bzr.dev >= r3309
  • unnamed Edit (189 bytes, application/pgp-signature; name=signature.asc)

On Mon, 2008-04-07 at 02:54 +0000, Jonathan Lange wrote:
> What is the "fixed http backend"? Is it in bzr.dev already?

I don't know the details; early last week, or the week before was when
it landed in bzr.dev.

-rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Tim Penhey (thumper) wrote :

RT to comment out apache config has been done.

Changed in launchpad-bazaar:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.