don't say "format: unnamed", give a sensible short name

Bug #202083 reported by Chris Halse Rogers
28
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned
Breezy
Triaged
Medium
Unassigned

Bug Description

Gnome-Do trunk (lp:do) is a branch using the dirstate format. When I branch this into a fresh repository using the (now) default pack-0.92, "bzr info" in the branch directory gives the somewhat strange output:
==============
Repository tree (format: unnamed)
Location:
  shared repository: /home/raof/Devel/GNOME-Do
  repository branch: .

Related branches:
  parent branch: bzr+ssh://<email address hidden>/%7Edo-core/do/trunk/
==============

Apparently, the "unnamed" format is there because there are two possible responses there (dirstate & pack-0.92), so bzr chooses neither. In such cases it would be less confusing to report this as something like:
==============
Repository tree (branch format: dirstate | repository format: pack-0.92)
...

Or some such.

Revision history for this message
Andrew Bennetts (spiv) wrote : Re: need better short names for format combinations

I think a concise alternative would be something like "format: dirstate/pack-0.92" in this case.

A workaround in the meantime is to use "bzr info -v" to find out what an "unnamed" format actually is.

Changed in bzr:
status: New → Confirmed
Revision history for this message
Andrew Bennetts (spiv) wrote :

Btw, I think in this case in your description you are probably *also* experiencing a separate bug, bug 196080, which is that "unnamed" is also be reported when using bzr+ssh:// URLs.

But this bug is still real: combinations like format 5 branches in pack-0.92 repos do report as "unnamed".

Martin Pool (mbp)
summary: - need better short names for format combinations
+ don't say "format: unnamed", give a sensible short name
summary: - don't say "format: unnamed", give a sensible short name
+ [master] don't say "format: unnamed", give a sensible short name
Changed in bzr:
importance: Undecided → Medium
Revision history for this message
Andrew Bennetts (spiv) wrote : Re: [master] don't say "format: unnamed", give a sensible short name

A trivial improvement might be to call it "mixed" rather than "unnamed". It's still not very helpful (and probably not sufficient to consider this bug fixed), but it is probably less alarming.

Revision history for this message
Lars Hoss (lars-hoss) wrote :

From a user's PoV who is not involved in technical details under the hood I prefer your suggestion from comment #1. In the context of shared repos I think that it is safe to say that the user expects repos inside a shared repo inherit the format of their master/parent. Therefore I feel the format name of the repo should reflect this. So things like "<format shared repo>/<format repo>" would be nice and helpful imho.

Revision history for this message
Andrew Bennetts (spiv) wrote :

As a user, I prefer my suggestion from #1 as well. But renaming "unnamed" to "mixed" is an improvement that takes almost no effort to implement, so it might be a good interim measure. Fixing the deeper problem is significantly more work (otherwise someone would have fixed this bug properly already!).

Revision history for this message
Aaron Bentley (abentley) wrote :

It would be pretty odd to call it dirstate/pack-0.92, because both of these are combinations of working tree, branch, and repository. The problem is not that the branch is *both*, the problem is that it's *neither*, and names like dirstate/pack-0.92 are not precise.

For example, consider dirstate/1.6: what branch format does this indicate: 5 or 7? What repository format?

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 202083] Re: [master] don't say "format: unnamed", give a sensible short name

Andrew Bennetts пишет:
> A trivial improvement might be to call it "mixed" rather than "unnamed".
> It's still not very helpful (and probably not sufficient to consider
> this bug fixed), but it is probably less alarming.

My 5 kopecks: I guess "mixed" is good, especially if you write also about -v option, e.g.

Repository tree (format: mixed, use bzr info -v to see more info)
...

Revision history for this message
Alexander Belchenko (bialix) wrote :

Alexander Belchenko пишет:
> Andrew Bennetts пишет:
>> A trivial improvement might be to call it "mixed" rather than "unnamed".
>> It's still not very helpful (and probably not sufficient to consider
>> this bug fixed), but it is probably less alarming.
>
> My 5 kopecks: I guess "mixed" is good, especially if you write also
> about -v option, e.g.
>
> Repository tree (format: mixed, use bzr info -v to see more info)

Or perhaps better wording would be:

Repository tree (format: mixed, use bzr info -v for details)

?

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
summary: - [master] don't say "format: unnamed", give a sensible short name
+ don't say "format: unnamed", give a sensible short name
tags: added: formatui
removed: check-for-breezy
Changed in brz:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.