Bazaar

can't pull knits to packs over hpss

Bug #165304 reported by Robert Collins
4
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Critical
Robert Collins
Bazaar 1.0rc1 "1.0alpha1"

Bug Description

e.g. pulling from a knit repo generates a data stream that a pack repo
cannot insert. Today, the pull will error and stop.

what we should do is transcode the data stream on the client at this
point.

See original description
Tags: hpss packs
Revision history for this message
Martin Pool (mbp) wrote :

> What should happen is that the pack repo will error today.

Do you mean it should error, but doesn't (and silently goes wrong)?

Revision history for this message
John A Meinel (jameinel) wrote :

I believe he first wants to make sure there are tests that it fails. I think it currently sends the hunks, which then get installed directly.
Knit => pack may know that it needs to strip the annotations, but I believe pack => knit doesn't realize it needs them. And yes, it results in bad data because then extracting from those knits will do the wrong thing.

Robert Collins (lifeless)
Changed in bzr:
assignee: nobody → mbp
Revision history for this message
Robert Collins (lifeless) wrote :

I've checked, insert_data_stream will error rather than adding incompatible data. So this will fail rather than doing something wrong.

description: updated
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 165304] Re: smart server data streams not used across repository representations

Is this the same as bug 165106? Or is that one just asking that it be
minimally safe, and this one that it be faster?

Revision history for this message
Martin Pool (mbp) wrote : Re: smart server data streams not used across repository representations

Bug 165304 just says that we should be minimally safe, which is true now. To fix this bug, we should check that hpss interoperation between packs and knits actually works smoothly.

Changed in bzr:
importance: Undecided → High
milestone: none → 1.0alpha1
status: New → Confirmed
Martin Pool (mbp)
Changed in bzr:
importance: High → Critical
status: Confirmed → In Progress
Robert Collins (lifeless)
Changed in bzr:
assignee: mbp → lifeless
Robert Collins (lifeless)
Changed in bzr:
status: In Progress → Fix Committed
Revision history for this message
Martin Pool (mbp) wrote :

This was put up for review, and had some tweak comments. Andrew's going to do them and put it up again.

Changed in bzr:
assignee: lifeless → spiv
Revision history for this message
Alexander Belchenko (bialix) wrote :

bzr.dev revno.3059

Changed in bzr:
assignee: spiv → lifeless
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.