LockContention just says "(remote lock)" not a useful url

I think LockContention can also occur when there are permission issues.

It just depends on the specific case. But certainly when it is a lock already held, it should be reported as such to the user.

Suggesting break-lock is bug 139202.

What's the context of this bug? I.e. when does the user see a bare LockContention rather than the usual verbose "Unable to obtain lock..." message?

(Another issue here is that the "(remote lock)" text isn't particularly helpful, but that ought to be tracked in a separate bug report, if it isn't already...)

On Tue, 2008-06-03 at 02:31 +0000, Andrew Bennetts wrote:
> Suggesting break-lock is bug 139202.
>
> What's the context of this bug? I.e. when does the user see a bare
> LockContention rather than the usual verbose "Unable to obtain lock..."
> message?

I can't remember now. I think the bug report may have stemmed from
helping a user on IRC when they got this message.

Thanks,

James

This makes LockContention include the lock file name in more cases, so
that you get some clue as to what's happening. I reproduced this
earlier while trying to branch from a branch while pushing it. (I
think that in turn is another instance of the shortcomings of
write-locking the dirstate to update the cache while doing a readonly
operation, but giving a better message here will make it more
obvious.)

This includes a bonus fix for the repr of SmartClientStreamMedium; see
the comment.

--
Martin <http://launchpad.net/~mbp/>

That patch looks reasonable to me... and I'd really like the repr fix to land ;)

I believe Martin landed this in bzr.dev r4114.

So there are a couple of problems here and I only fixed one of them. I think my particular fix was actually for dirstate contention, not remote branches as in James's original example.

For remote branches we still just say "(remote lock)".

Also per bug 342102 we're apparently not polling the lock as we should be.

I think Parth has done a lot of work on this, and this is a likely duplicate now. Subscribing him for his comment.