unable to push to packs-based smart server
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Critical
|
Robert Collins |
Bug Description
Bazaar (bzr) 0.92.0.dev.0
from bzr checkout /afs/isgenesis.
revision: 2852
revid: <email address hidden>
branch nick: bzr-packs.rcollins
Python interpreter: /usr/bin/python 2.4.4.final.0
Python standard library: /usr/lib/python2.4
bzrlib: /afs/isgenesis.
Bazaar configuration: /afs/isgenesis.
Bazaar log file: /afs/isgenesis.
(same version on both client and server; server is operating against a packs-backend repository)
===
$ time bzr-packs push bzr://gentoo-
bzr: ERROR: Could not understand response from smart server: ('error', "<bound method GraphKnitReposi
real 5m20.247s
user 3m11.316s
sys 0m2.972s
===
Traceback (most recent call last):
File "/home/
self.
File "/home/
self.
File "/home/
result = self._call_
File "/home/
return callable(*args, **kwargs)
File "/home/
return self.do(*args)
File "/home/
return self.do_
File "/home/
repository.
File "/afs/isgenesis
raise NotImplementedE
NotImplementedE
Changed in bzr: | |
milestone: | none → 1.0rc1 |
Changed in bzr: | |
importance: | High → Critical |
Changed in bzr: | |
status: | Triaged → Confirmed |
Changed in bzr: | |
assignee: | nobody → lifeless |
status: | Confirmed → Fix Released |
In discussing this with Robert, there are 2 pieces.
a) leave_lock_ in_place( ) was actually supposed to be optional for implementations
b) Pack style repositories shouldn't actually be locking at this level. The physical (on-disk) lock is only taken out when updating the pack names list, and should be done by the smart server, and not the client.