Bazaar

bzr commit to bzr+ssh hangs on 'No handlers could be found for logger "bzr"'

Bug #152746 reported by Bruce Kroeze
6
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Unassigned
Launchpad itself
Fix Released
High
Jonathan Lange

Bug Description

Using bzr 0.91, and confirmed on 0.92.0.dev.0
---
Committing changes to launchpad:

[13:18:30][user@Bruce-Kroeze-Laptop:/opt/webapps/banjo]$ bzr info

Repository checkout (format: dirstate-tags)
Location:
  repository checkout root: .
        checkout of branch: bzr+ssh://<email address hidden>/%7Ebkroeze/banjo/banjo/
         shared repository: /Users/user/work/banjo

Related branches:
  push branch: bzr+ssh://<email address hidden>/%7Ebkroeze/banjo/banjo/

---
[13:18:38][user@Bruce-Kroeze-Laptop:/opt/webapps/banjo]$ bzr commit
No handlers could be found for logger "bzr"

Bazaar hangs indefinitely at this point.

Tried several times, using two different computers, both Mac OSX 10.4. Also tested using a different repository target and it worked fine. That one was an sftp server.

Finally got it to work by this modification (on 0.92.0.dev.0)

=== modified file 'bzrlib/smart/protocol.py'
--- bzrlib/smart/protocol.py 2007-08-13 01:04:05 +0000
+++ bzrlib/smart/protocol.py 2007-10-14 20:28:17 +0000
@@ -357,9 +357,9 @@
         result = self._recv_tuple()
         if 'hpss' in debug.debug_flags:
             if self._request_start_time is not None:
- mutter(' result: %6.3fs %s',
- time.time() - self._request_start_time,
- repr(result)[1:-1])
+ #mutter(' result: %6.3fs %s',
+ # time.time() - self._request_start_time,
+ # repr(result)[1:-1])
                 self._request_start_time = None
             else:
                 mutter(' result: %s', repr(result)[1:-1])

Tags: lp-code
Revision history for this message
Bruce Kroeze (bkroeze) wrote :

Note, I cannot give you a bzr selftest, because it hangs during ssh tests if I try.

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 152746] bzr commit to bzr+ssh hangs on 'No handlers could be found for logger "bzr"'

Thankyou for the report and analysis.

It's very strange that this code is even being reached if you're not
running with -Dhpss - did you turn that on somewhere?

--
Martin

Revision history for this message
Bruce Kroeze (bkroeze) wrote :

Not that I know of. I wouldn't know how to do that if I wanted to do so.

On 10/14/07, Martin Pool <email address hidden> wrote:
>
> Thankyou for the report and analysis.
>
> It's very strange that this code is even being reached if you're not
> running with -Dhpss - did you turn that on somewhere?
>
> --
> Martin
>
> --
> bzr commit to bzr+ssh hangs on 'No handlers could be found for logger
> "bzr"'
> https://bugs.launchpad.net/bugs/152746
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
Mike C. Delorme (mdelorme) wrote :

Confirmed in bzr 0.91

Changed in bzr:
status: New → Confirmed
Revision history for this message
Jonathan Lange (jml) wrote :

The hanging issue is a Bazaar bug, but the error with logging is definitely Launchpad's problem.

After talking with spiv, it seems the hanging is caused by an overly long timeout in bzrlib/lockdir.py. We can (and probably will) work around it in Launchpad.

Changed in launchpad-bazaar:
assignee: nobody → jml
importance: Undecided → High
milestone: none → 1.1.11
status: New → Triaged
Revision history for this message
Jonathan Lange (jml) wrote :

Waiting for review.

Changed in launchpad-bazaar:
status: Triaged → In Progress
Jonathan Lange (jml)
Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
Martin Pool (mbp) wrote :

To clarify, it seems the bug in Bazaar is that it sends an RPC to take the lock, and does not give any feedback while waiting for it to complete.

Changed in bzr:
importance: Undecided → High
Revision history for this message
David Allouche (ddaa) wrote :

> Waiting for review.

This is a bit unfair. "In review" would be better.

The initial review was done, insufficient tests and documentation were found, and the branch is currently "needs-reply", waiting on jml to come back from leave to address the review comments.

Changed in launchpad-bazaar:
status: Fix Committed → In Progress
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 152746] Re: bzr commit to bzr+ssh hangs on 'No handlers could be found for logger "bzr"'

On Tue, 2007-11-20 at 15:13 +0000, David Allouche wrote:
> > Waiting for review.
>
> This is a bit unfair. "In review" would be better.
>
> The initial review was done, insufficient tests and documentation were
> found, and the branch is currently "needs-reply", waiting on jml to come
> back from leave to address the review comments.

It should be changed to a different reviewer at this point; a blocked
branch just ages.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
David Allouche (ddaa) wrote :

> It should be changed to a different reviewer at this point; a blocked
> branch just ages.

It is not blocked on the reviewer (that is, me). I reviewed it and set it as needs-reply. Jonathan is on vacation and has not addressed the review yet.

Revision history for this message
Jonathan Lange (jml) wrote :

FWIW, when I said it was waiting for review, it actually was waiting for review.

Revision history for this message
Jonathan Lange (jml) wrote :

This slipped 1.11. Continuing as High priority for 1.12.

Changed in launchpad-bazaar:
milestone: 1.1.11 → 1.1.12
Revision history for this message
Jonathan Lange (jml) wrote :

Fix to LP logging system landed.

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
Kees Cook (kees) wrote :

I suddenly can't commit to https://code.launchpad.net/~ubuntu-security/ubuntu-cve-tracker/master anymore; I'm hitting this bug. While it hung, it did eventually fail:

$ bzr ci -m 'add CVE for e2fsprogs'
No handlers could be found for logger "bzr"
bzr: ERROR: Could not acquire lock "(remote lock)"

Is there a work-around for this?

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 152746] Re: bzr commit to bzr+ssh hangs on 'No handlers could be found for logger "bzr"'

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kees Cook wrote:
> I suddenly can't commit to https://code.launchpad.net/~ubuntu-security
> /ubuntu-cve-tracker/master anymore; I'm hitting this bug. While it
> hung, it did eventually fail:
>
> $ bzr ci -m 'add CVE for e2fsprogs'
> No handlers could be found for logger "bzr"
> bzr: ERROR: Could not acquire lock "(remote lock)"
>
> Is there a work-around for this?
>

When you run into it, do ^C

Then
bzr break-lock bzr+ssh://bazaar.launchpad.net/~ubuntu-security/...
bzr break-lock bzr+ssh://bazaar.launchpad.net/~ubuntu-security/...

You have to run 2 break-locks, because there is a bzr process waiting around on
the other end to lock it for you.

In fact, you could loop the break-lock until it gives no output (since
break-lock won't complain if the lock isn't locked).

Just make sure that there really isn't anyone pushing to the directory.
Otherwise 2 people pushing to the same repository can intermix writes and
corrupt data.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHWaEMJdeBCYSNAAMRAsR2AKCEAGpvwphFJNB5yNtjQLRXgLf3dQCcD8p5
YAy7a9p+MX8z9siURoBbqds=
=ExtT
-----END PGP SIGNATURE-----

Revision history for this message
Andrew Bennetts (spiv) wrote :

bzr break-lock bzr+ssh:// can fail to break the lock (or rather, it breaks the lock but immediately acquires a new one and leaves it behind, so the branch is still left with a stale lock). That is bug 148087. The workaround is to do "bzr break-lock sftp://..." instead, which works reliably.

Jonathan Lange (jml)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
Revision history for this message
Jonathan Lange (jml) wrote :

I think this is fixed in Bazaar. Andrew, can you please confirm and close?

Revision history for this message
Andrew Bennetts (spiv) wrote :

I believe this is fixed in Bazaar, too.

Changed in bzr:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.