Bazaar

'RemoteRepository' object has no attribute '_make_parents_provider' - bundle command fails with bzr remote repositories

Bug #147836 reported by Daniel Bültmann
12
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Andrew Bennetts
Bazaar 1.0rc2

Bug Description

The bzr bundle command fails with a traceback when the remote repository is contacted using the bzr protocol.

I have published a branch to a location served by bzr serve (e.g. bzr://localhost/main/someproject--main--3.0).

Then I branched from that location : bzr branch bzr://localhost/main/someproject--main--3.0

After changing to the someproject--main--3.0 directory I changed some files. I did not commit but wanted bzr
to bundle these changes. I issued "bzr bundle" and got the following Python backtrace:

dbn@beast:/net/beast1/DBN/dbn/src//someproject--main--3.0> bzr bundle
bzr: ERROR: exceptions.AttributeError: 'RemoteRepository' object has no attribute '_make_parents_provider'

Traceback (most recent call last):
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commands.py", line 817, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commands.py", line 779, in run_bzr
    ret = run(*run_argv)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commands.py", line 477, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/builtins.py", line 3978, in run
    kwargs.get('from', '.'))
  File "/usr/local/lib/python2.4/site-packages/bzrlib/builtins.py", line 3906, in _run
    base_revision_id=base_revision_id)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/merge_directive.py", line 451, in from_objects
    graph = repository.get_graph(submit_branch.repository)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/repository.py", line 1032, in get_graph
    parents_provider = graph._StackedParentsProvider(
AttributeError: 'RemoteRepository' object has no attribute '_make_parents_provider'

bzr 0.90.0 on python 2.4.2.final.0 (linux2)
arguments: ['/usr/local/bin/bzr', 'bundle']

** please send this report to <email address hidden>

(Also applies to current bzr.dev)

See original description
James Westby (james-w)
description: updated
Revision history for this message
James Westby (james-w) wrote :

Aaron, annotate says that you added the method to repository.py, do you have any hints
on the what RemoteRepository should implement for this?

Martin Pool (mbp)
Changed in bzr:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 147836] Re: 'RemoteRepository' object has no attribute '_make_parents_provider' - bundle command fails with bzr remote repositories

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Westby wrote:
> Aaron, annotate says that you added the method to repository.py, do you have any hints
> on the what RemoteRepository should implement for this?

For now, you can use ensure_real. Hopefully, there will someday be a
RemoteGraph object that can be returned instead of using
_make_parents_provider at all.

Aaron

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHBbVH0F+nu1YWqI0RAhISAJ9ivqauMBhwzrPHHctkuzYEnbKgFQCfc2um
XU0XUN9oAQmBydbK+RlSWnI=
=mTlX
-----END PGP SIGNATURE-----

Revision history for this message
Curtis Hovey (sinzui) wrote :

I incorporated a bzr status into our `make lint` to report on the changes from the parent branch. Developers who branched from /rocketfuel/launchpad/devel get this same error, but I note that when the protocol is switched from bzr+ssh to sftp, it works fine.

bzr status --short -r ancestor:bzr+ssh://<hidden>/rocketfuel/launchpad/devel
bzr: ERROR: exceptions.AttributeError: 'RemoteRepository' object has no attribute '_make_parents_provider'

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 802, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 758, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 492, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 768, in ignore_pipe
    result = func(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 189, in run
    to_file=self.outf, short=short, versioned=versioned)
  File "/usr/lib/python2.5/site-packages/bzrlib/status.py", line 87, in show_tree_status
    rev_id = revision[0].in_history(wt.branch).rev_id
  File "/usr/lib/python2.5/site-packages/bzrlib/revisionspec.py", line 225, in in_history
    return self._match_on_and_check(branch, revs)
  File "/usr/lib/python2.5/site-packages/bzrlib/revisionspec.py", line 207, in _match_on_and_check
    info = self._match_on(branch, revs)
  File "/usr/lib/python2.5/site-packages/bzrlib/revisionspec.py", line 630, in _match_on
    return self._find_revision_info(branch, self.spec)
  File "/usr/lib/python2.5/site-packages/bzrlib/revisionspec.py", line 644, in _find_revision_info
    graph = branch.repository.get_graph(other_branch.repository)
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 1493, in get_graph
    [parents_provider, other_repository._make_parents_provider()])
AttributeError: 'RemoteRepository' object has no attribute '_make_parents_provider'

bzr 0.92.0.candidate.1 on python 2.5.1.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'status', '--short', '-r', 'ancestor:bzr+ssh://devpad.canonical.com/code/rocketfuel/launchpad/devel']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [0.92.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  multiparent /usr/lib/python2.5/site-packages/bzrlib/plugins/multiparent.pyc [unknown]
  pqm /usr/lib/python2.5/site-packages/bzrlib/plugins/pqm [unknown]

Andrew Bennetts (spiv)
Changed in bzr:
assignee: nobody → spiv
status: Confirmed → Fix Committed
Revision history for this message
Andrew Bennetts (spiv) wrote :

This fix landed in bzr.dev on Friday (2007-12-07).

Changed in bzr:
status: Fix Committed → Fix Released
milestone: none → 1.0rc2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.