bzr-stats

committer-stats assumes everyone with no email is the same person

Bug #250652 reported by Matthew Fuller
4
Affects Status Importance Assigned to Milestone
bzr-stats
Fix Released
Low
Paul Hummer

Bug Description

committer-stats collapses down users with the same email and different usernames and assumes they're the same person. This is a reasonable thing to do in general; however, it shouldn't be done when the email address is empty (as can happen from other system conversions, where config.parse_username returns the existing bit as username and an empty email).

A quick glance at the code suggests that the email is used as a key very early on, so this isn't a quick fix.

Related branches

lp:~rockstar/bzr-stats/import-branch-support
Jelmer Vernooij (community): Approve
John A Meinel: Approve (A good one)
Paul Hummer (rockstar)
Changed in bzr-stats:
assignee: nobody → rockstar
status: New → In Progress
Revision history for this message
Lukáš Lalinský (luks) wrote :

I think I have a better fix for this in lp:~luks/bzr-stats/stats

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Lukas, Any chance you can submit your fix to bundlebuggy?

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

It would be nice to at least merge the tests you added :-)

Revision history for this message
Lukáš Lalinský (luks) wrote :

I can, but only the whole branch with contains also other changes, which wouldn't be that useful :) Maybe I'll split the branch and send separate patches later.

Revision history for this message
Paul Hummer (rockstar) wrote :

This got merged into bzr-stats a more than a month ago.

Changed in bzr-stats:
importance: Undecided → Low
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.