Doesn't know about non-command help topics
Bug #396261 reported by
Matt Nordhoff
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Undecided
|
Robert Collins | ||
bzr-guess |
Confirmed
|
Wishlist
|
Unassigned |
Bug Description
This is likely the fault of bzr's help infrastructure, but...
Look:
$ bzr help hidden-commands
Command 'hidden-commands' not found, perhaps you meant 'sign-my-commits'? [y/n]: n
added List files added in working tree.
...
$ bzr help topics
Command 'topics' not found, perhaps you meant 'rocks'? [y/n]: n
authentication Information on configuring authentication
...
bzr-guess doesn't seem to think these topics exist, even though the help information comes up normally after I dismiss its prompt.
bzr.dev r4512, bzr-guess r1.
Related branches
lp:~amanica/bzr-guess/QnD_dont_guess_help_topics
Merged
into
lp:bzr-guess
- Robert Collins (community): Approve
- Vincent Ladeuil: Approve
-
Diff: 30 lines1 file modified__init__.py (+6/-0)
lp:~lifeless/bzr/commandlookup
- Martin Pool: Approve
-
Diff: 114 lines (+35/-14)3 files modifiedNEWS (+6/-0)
bzrlib/commands.py (+5/-3)
bzrlib/tests/test_commands.py (+24/-11)
description: | updated |
description: | updated |
Changed in bzr-guess: | |
assignee: | nobody → Marius Kruger (amanica) |
status: | Confirmed → Fix Committed |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
status confirmed
importance critical
If you want to fix it, I suggest querying for topics and if the command
being looked up is a topic just bail out with None early. This is
happening because the 'command' help topic just asks for the command.
Doing what I suggest here will mean that 'bzr hidden-commands' will
return no such command and not suggest one - which I think is fine.
-Rob