Timezone with offset 0 encoded as +0000 by Dulwich while git has -0000

Bug #539978 reported by Tim Penhey
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Bazaar Git Plugin
Fix Released
Medium
Jelmer Vernooij
Dulwich
Fix Released
Medium
Jelmer Vernooij
Launchpad itself
Fix Released
Medium
Unassigned

Bug Description

https://code.edge.launchpad.net/~vcs-imports/iso-codes/master is failing to import.

AssertionError: Invalid sha for <Commit 4caecbf7694161d65c6474d416d72f469fcf44a5>: ff3931573b3fbd22641f257ea4cf207fd88ae8a4

Full import log here:
http://launchpadlibrarian.net/41058010/vcs-imports-iso-codes-master-log.txt

Related branches

Tim Penhey (thumper)
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Medium
tags: added: code-import
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

The bug appears to be in the way that Dulwich formats timezones:

tree c0105a8db0ae1d9a7994bf8f81500853cf59eba8
author Alastair McKinstry <email address hidden> 1077476286 +0000
committer Alastair McKinstry <email address hidden> 1077476286 +0000

Initial revision

Whereas the following is expected:

tree c0105a8db0ae1d9a7994bf8f81500853cf59eba8
author Alastair McKinstry <email address hidden> 1077476286 -0000
committer Alastair McKinstry <email address hidden> 1077476286 -0000

Initial revision

Changed in bzr-git:
status: New → Triaged
importance: Undecided → Medium
Changed in dulwich:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Git seems to allow both +0000 and -0000

summary: - Invalid sha importing iso-codes
+ Timezone with offset 0 encoded as +0000 by Dulwich while git has -0000
Jelmer Vernooij (jelmer)
Changed in bzr-git:
status: Triaged → Fix Released
Changed in dulwich:
status: Triaged → Fix Released
Changed in bzr-git:
assignee: nobody → Jelmer Vernooij (jelmer)
Changed in dulwich:
assignee: nobody → Jelmer Vernooij (jelmer)
Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.