Ubuntu
vpnc package

0.5.3r512 cannot be built with dpkg-buildpackage due to "unexpected upstream changes"

Bug #992543 reported by Reuben Firmin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vpnc (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

I need vpnc with OPENSSL_GPL_VIOLATION compiled in. I wish Ubuntu would just package it up as vpnc-nonfree or similar, but regardless.

My procedure with prior versions has been to:

apt-get install libssl-dev
apt-get source vpnc
cd vpnc-0.5.3r449/
vim Makefile #uncomment OPENSSL_GPL_VIOLATION line
apt-get build-dep vpnc
dpkg-buildpackage

This no longer works wit 0.5.3r512. The output is below:

rfirmin@fridge:~/vpnc-0.5.3r512$ sudo dpkg-buildpackage
dpkg-buildpackage: source package vpnc
dpkg-buildpackage: source version 0.5.3r512-2ubuntu1
dpkg-buildpackage: source changed by Evan Broder <email address hidden>
dpkg-buildpackage: host architecture amd64
 dpkg-source --before-build vpnc-0.5.3r512
 debian/rules clean
dh clean
   dh_testdir
   dh_auto_clean
make[1]: Entering directory `/home/rfirmin/vpnc-0.5.3r512'
rm -f sysdep.o vpnc-debug.o isakmp-pkt.o tunip.o config.o dh.o math_group.o supp.o decrypt-utils.o crypto.o crypto-openssl.o vpnc.o cisco-decrypt.o test-crypto.o vpnc cisco-decrypt test-crypto tags
rm -f vpnc-debug.c vpnc-debug.h vpnc.ps vpnc.8 .depend
make[1]: Leaving directory `/home/rfirmin/vpnc-0.5.3r512'
   dh_clean
 dpkg-source -b vpnc-0.5.3r512
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building vpnc using existing ./vpnc_0.5.3r512.orig.tar.gz
dpkg-source: info: local changes detected, the modified files are:
 vpnc-0.5.3r512/Makefile
dpkg-source: info: you can integrate the local changes with dpkg-source --commit
dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/vpnc_0.5.3r512-2ubuntu1.diff.8Wi0LF
dpkg-buildpackage: error: dpkg-source -b vpnc-0.5.3r512 gave error exit status 2

I will attach the referred to diff file.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: vpnc (not installed)
ProcVersionSignature: Ubuntu 3.2.0-24.37-generic 3.2.14
Uname: Linux 3.2.0-24-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.0.1-0ubuntu6
Architecture: amd64
Date: Tue May 1 07:36:37 2012
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111012)
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: vpnc
UpgradeStatus: Upgraded to precise on 2012-04-27 (3 days ago)
modified.conffile..etc.vpnc.default.conf: [deleted]
modified.conffile..etc.vpnc.vpnc.script: [deleted]

Revision history for this message
Reuben Firmin (reubenf) wrote :

Launchpad wouldn't let me attach it. Here's a paste of the file:

Description: <short summary of the patch>
 TODO: Put a short summary on the line above and replace this paragraph
 with a longer explanation of this change. Complete the meta-information
 with other relevant fields (see below for details). To make it easier, the
 information below has been extracted from the changelog. Adjust it or drop
 it.
 .
 vpnc (0.5.3r512-2ubuntu1) precise; urgency=low
 .
   * Added fetch-split-dns-prop.patch to fetch split DNS property from
     Cisco VPN servers. (LP: #954747)
Author: Evan Broder <email address hidden>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/954747

---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>

--- vpnc-0.5.3r512.orig/Makefile
+++ vpnc-0.5.3r512/Makefile
@@ -39,7 +39,7 @@ DOCDIR=$(PREFIX)/share/doc/vpnc

 # Comment this in to obtain a binary with certificate support which is
 # GPL incompliant though.
-#OPENSSL_GPL_VIOLATION=yes
+OPENSSL_GPL_VIOLATION=yes

 CRYPTO_LDADD = $(shell pkg-config --libs gnutls)
 CRYPTO_CFLAGS = $(shell pkg-config --cflags gnutls) -DCRYPTO_GNUTLS

Revision history for this message
Stefano Rivera (stefanor) wrote :

We use quilt for managing patches

http://wiki.debian.org/UsingQuilt

Or if you don't want to learn how to use it, just use dpkg-source --commit, as the error suggests.

Changed in vpnc (Ubuntu):
status: New → Invalid
Revision history for this message
Reuben Firmin (reubenf) wrote :

That's fine (and I will look into it), but did this deliberately change between 0.5.3r449 and 0.5.3r512? Surely there were patches in r449 that did not trip up buildpackage.

Per my description, the buildpackage route worked fine on 0.5.3r449.

Reopening just to get an answer for this. If "yes" then I don't think there's an issue. If "no" can you explain why there's a difference? Perhaps this indicates a bug in some other library?

Changed in vpnc (Ubuntu):
status: Invalid → Incomplete
status: Incomplete → New
Revision history for this message
Stefano Rivera (stefanor) wrote :

Note in the changelog entry for 0.5.3r449-3:
   * Use source "3.0 (quilt)"

3.0 (quilt) is used in most packages these days:
http://upsilon.cc/~zack/stuff/dpkg-v3/

Please stick your nose into #ubuntu-packaging, if you want some help.

Changed in vpnc (Ubuntu):
status: New → Invalid
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Unfortunately, we can't even ship vpnc with that change, since the actual license violation remains an issue which prohibits us shipping the package.

If you want to email me to explain the reason why you need vpnc to be compiled against OPENSSL, which I thought we had already all fixed in recent vpnc versions; please do so -- I'd love to hear about your particular use case, so that we can possibly fix it for the next Ubuntu release (and no longer require building against openssl)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.