bzr 0.13 does not respect proxy env vars with urllib

There is two implementations handling the http protocol: pycurl and urllib.

pycurl is an package distinct from bzr while urllib is pure python.

If the DNS error was transient (as the error message implies), it may be that using pycurl was not related to the bug, but pycurl do DNS caching so that may help.

Can you reproduce it ?

If you can, please use bzr branch http+urllib://bazaar-vcs.org/bzr/bzr.0.13 to force the use of the urllib implementation and attach $HOME/.bzr.log and an ethereal dump.

vila wrote:
> There is two implementations handling the http protocol: pycurl and
> urllib.
>
> pycurl is an package distinct from bzr while urllib is pure python.
>
> If the DNS error was transient (as the error message implies), it may be
> that using pycurl was not related to the bug, but pycurl do DNS caching
> so that may help.
>
> Can you reproduce it ?
>
> If you can, please use bzr branch http+urllib://bazaar-
> vcs.org/bzr/bzr.0.13 to force the use of the urllib implementation and
> attach $HOME/.bzr.log and an ethereal dump.
>
> ** Changed in: bzr (upstream)
> Assignee: (unassigned) => vila
>
Ok, Here is my .bzr.log for the relevant part:

looking for plugins in /usr/lib/python2.4/site-packages/bzrlib/plugins
Plugin name __init__ already loaded
add plugin name launchpad
Plugin name __init__ already loaded
load plugin (None,
'/usr/lib/python2.4/site-packages/bzrlib/plugins/launchpad', ('', '', 5))
registered plugin command register-branch
loaded succesfully
looking for plugins in /home/david/.bazaar/plugins
add plugin name svn
load plugin (None, '/home/david/.bazaar/plugins/svn', ('', '', 5))
registered plugin command import-svn
loaded succesfully
encoding stdout as sys.stdout encoding 'UTF-8'
GET: [http://bazaar-vcs.org/bzr/bzr.0.13/.bzr/branch-format]
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 626,
in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 588,
in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 292,
in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.4/site-packages/bzrlib/builtins.py", line 718,
in run
    br_from = Branch.open(from_location)
  File "/usr/lib/python2.4/site-packages/bzrlib/branch.py", line 118, in
open
    control = bzrdir.BzrDir.open(base, _unsupported)
  File "/usr/lib/python2.4/site-packages/bzrlib/bzrdir.py", line 495, in
open
    return BzrDir.open_from_transport(t, _unsupported=_unsupported)
  File "/usr/lib/python2.4/site-packages/bzrlib/bzrdir.py", line 504, in
open_from_transport
    format = BzrDirFormat.find_format(transport)
  File "/usr/lib/python2.4/site-packages/bzrlib/bzrdir.py", line 1054,
in find_format
    return format.probe_transport(transport)
  File "/usr/lib/python2.4/site-packages/bzrlib/bzrdir.py", line 1064,
in probe_transport
    format_string = transport.get(".bzr/branch-format").read()
  File
"/usr/lib/python2.4/site-packages/bzrlib/transport/http/__init__.py",
line 226, in get
    code, response_file = self._get(relpath, None)
  File
"/usr/lib/python2.4/site-packages/bzrlib/transport/http/_urllib.py",
line 130, in _get
    response = self._perform(request)
  File
"/usr/lib/python2.4/site-packages/bzrlib/transport/http/_urllib.py",
line 102, in _perform
    response = self._opener.open(request)
  File "urllib2.py", line 358, in open
    response = self._open(req, data)
  File "urllib2.py", line 376, in _open
    '_open', req)
  File "urllib2.py", line 337, in _call_chain
    result = func(*args)
  File
"/usr/lib/python2.4/site-packages/bzrlib/transport/...

I just changed the title, the problem is with proxy env vars.

More precisely, the bug is due to an interaction between connection sharing and proxy setting. Works in progress.

Fix attached for tests.

Test suite fix will follows.

Importance set to medium. All 0.13 users trying to access repositories thru proxies are affected.

The fix is incomplete, it incorrectly handles the no_proxy env variable.

The interim work-around is to use pycurl instead.

Better fix, but still no tests.

We catchup pycurl a bit and do better than urllib2.