_pretty_needs_read_lock breaks symbol_versioning.deprecated_passed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Critical
|
Andrew Bennetts |
Bug Description
Running lp:udd's import_package.py locally to test something with bzrlib from lp:bzr I just got this traceback:
Traceback (most recent call last):
File "./import_
persistent_
File "./import_
revid_db, bstore, possible_
File "./import_
possible_
File "./icommon.py", line 1339, in get_branch
possible_
File "./icommon.py", line 1503, in get_branch_parts
dir = br_from.
File "/home/
create_
File "/home/
self.cleanups, self.func, self, *args, **kwargs)
File "/home/
result = func(*args, **kwargs)
File "/home/
fetch_spec = fetch_spec_
File "/home/
required_
File "/home/
if_
File "<string>", line 4, in search_
File "/home/
'revision_ids is mutually exclusive with revision_id')
AssertionError: revision_ids is mutually exclusive with revision_id
It turns out that this is because search_
This doesn't affect the 'bzr' tool, but will break other tools that use bzrlib without enabling the fast decorators (i.e. most of them).
Related branches
- Vincent Ladeuil: Approve
-
Diff: 153 lines (+47/-9)3 files modifiedbzrlib/decorators.py (+22/-8)
bzrlib/tests/test_decorators.py (+21/-1)
doc/en/release-notes/bzr-2.4.txt (+4/-0)
Changed in bzr: | |
status: | Confirmed → In Progress |
Changed in bzr: | |
milestone: | none → 2.4b1 |
status: | In Progress → Fix Released |
In fact because this stops trunk lp:bzr working with lp:udd I'm going to mark this as critical.