zeitgeist-daemon.py has a bad code structure
Bug #660415 reported by
Markus Korn
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zeitgeist Framework |
Fix Released
|
Wishlist
|
Markus Korn | ||
Bug Description
The code of zeitgeist-daemon.py is very hard to read, let's restructure the code!
(This is more like a reminder for myself to work on it, but I would like to fix it after bug #655164 has been fixed)
Related branches
lp:~thekorn/zeitgeist/fix-660415-improve-zeitgeist-daemon
- Seif Lotfy: Approve
-
Diff: 300 lines (+86/-79)10 files modified_zeitgeist/engine/__init__.py (+0/-1)
_zeitgeist/engine/extension.py (+0/-1)
_zeitgeist/engine/extensions/blacklist.py (+0/-1)
_zeitgeist/engine/extensions/datasource_registry.py (+0/-1)
_zeitgeist/engine/main.py (+0/-1)
_zeitgeist/engine/notify.py (+0/-1)
_zeitgeist/engine/sql.py (+0/-1)
_zeitgeist/engine/upgrades/core_0_1.py (+0/-1)
zeitgeist-daemon.py (+86/-70)
zeitgeist/client.py (+0/-1)
| Changed in zeitgeist: | |
| assignee: | nobody → Markus Korn (thekorn) |
Revision history for this message
| Markus Korn (thekorn) wrote | #1 |
| Changed in zeitgeist: | |
| milestone: | none → 0.6 |
| status: | New → Confirmed |
| importance: | Undecided → Wishlist |
| summary: |
- zeitgeist-daemon has a bad code structure + zeitgeist-daemon.py has a bad code structure |
| description: | updated |
| Changed in zeitgeist: | |
| status: | Confirmed → In Progress |
| Changed in zeitgeist: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Markus Korn (thekorn) wrote | #2 |
| Changed in zeitgeist: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
small note to self: check if using glib.spawn_async() instead of subprocess.Popen() to launch the datahub makes sense (is it consuming less memory? is it easier to react on datahub failures?)