Launchpad itself

dkim-signed mail to new@bugs doesn't work

Bug #643219 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Martin Pool
Launchpad itself 10.12

Bug Description

Continuing from bug 316272: dkim-authenticated mail to change the state of an existing bug works, but mail to new@bugs is rejected.

The problem seems to be that MaloneHandler.process redundantly checks the mail has gpg signature, rather than trusting the earlier code that checks whether or not it's authenticated.

Related branches

lp:~mbp/launchpad/dkim
Jonathan Lange (community): Approve
Graham Binns: Pending (code) requested
Launchpad code reviewers: Pending requested
Diff: 914 lines (+267/-117)
9 files modified
lib/canonical/launchpad/doc/emailauthentication.txt (+16/-10)
lib/canonical/launchpad/mail/handlers.py (+54/-49)
lib/canonical/launchpad/mail/helpers.py (+20/-2)
lib/canonical/launchpad/mail/tests/test_handlers.py (+61/-0)
lib/lp/bugs/tests/bugs-emailinterface.txt (+39/-36)
lib/lp/services/mail/incoming.py (+28/-5)
lib/lp/services/mail/tests/incomingmail.txt (+24/-13)
lib/lp/services/mail/tests/test_incoming.py (+24/-1)
utilities/migrater/file-ownership.txt (+1/-1)
Jonathan Lange (community): Approve
Graham Binns (community): Approve (code)
Launchpad code reviewers: Pending requested
Diff: 1080 lines (+288/-135)
13 files modified
lib/canonical/buildd/test_buildd_recipe (+1/-1)
lib/canonical/launchpad/doc/emailauthentication.txt (+16/-10)
lib/canonical/launchpad/mail/handlers.py (+55/-49)
lib/canonical/launchpad/mail/helpers.py (+20/-2)
lib/canonical/launchpad/mail/tests/test_handlers.py (+61/-0)
lib/lp/bugs/tests/bugs-emailinterface.txt (+38/-35)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+13/-13)
lib/lp/code/interfaces/sourcepackagerecipe.py (+1/-1)
lib/lp/code/model/tests/test_recipebuilder.py (+6/-4)
lib/lp/services/mail/incoming.py (+28/-5)
lib/lp/services/mail/tests/incomingmail.txt (+24/-13)
lib/lp/services/mail/tests/test_incoming.py (+24/-1)
utilities/migrater/file-ownership.txt (+1/-1)
Revision history for this message
Martin Pool (mbp) wrote :

Now I think fixed in lp:~mbp/launchpad/dkim, but needs a test.

Jonathan Lange (jml)
tags: added: dkim
Jonathan Lange (jml)
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r12008 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12008>.

Changed in launchpad-foundations:
milestone: none → 10.12
tags: added: qa-needstesting
Revision history for this message
Martin Pool (mbp) wrote :

I testing this on staging as follows:

* mail without a valid dkim signature is rejected as previously
* mail with a valid dkim signature to new creates a new bug <https://bugs.staging.launchpad.net/launchpad/+bug/684521>
* mail with a valid GPG signature is still accepted <https://bugs.staging.launchpad.net/launchpad/+bug/684522>

Revision history for this message
Martin Pool (mbp) wrote :

Also tested that mail with no signature that only adds a comment is still accepted. So I think this is all safely working with no regressions.

Martin Pool (mbp)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.