QBzr

bzr command output is not shown in qbzr output window

Bug #640082 reported by Gordon Tyler
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Critical
Gary van der Merwe
QBzr 0.19.2

Bug Description

Using bzr 2.2.0 and qbzr 0.19.0, installed from the Windows installer, on Windows 7 64bit.

Trying to branch from LP and it was just doing nothing and showing me the "Retry" button with no error messages in the output window. So I checked my bzr.log file and it has paramiko errors (I'd forgotten to add my SSH key to pagent). These used to be shown in the output window in bzr 2.1.

In fact, it looks like no output from bzr commands is being shown in the output window at all. Once I'd added my SSH key to pagent, I clicked the Retry button in the qbzr Branch window and this time it sat there for a while with the button disabled and the Status message saying "Starting...". Then it said "Finished!" and no other output in the output window. The command actually worked but none of the usual feedback was visible.

Related branches

lp:qbzr/0.19
Gordon Tyler (doxxx)
summary: - paramiko errors are not shown in output window
+ bzr command output is not shown in qbzr output window
Revision history for this message
Alexander Belchenko (bialix) wrote :

I think you hit the bug #632501 or something similar. We're going to downgrade PyQt to 4.5 in the next installer (2.2.1 most likely) and this might help.

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

So this happens with bzrw.exe, but not bzr.exe.

Alexander added code to subprocess.py to make it use bzr.exe and not bzrw.exe. This was not correcty working, and I have landed a patch for this.

I am also investigating makeing bzrw still write to stdout/stderr. This may be usefull to other people interfacing with bzr.

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 640082] Re: bzr command output is not shown in qbzr output window

Gary van der Merwe пишет:
> So this happens with bzrw.exe, but not bzr.exe.
>
> Alexander added code to subprocess.py to make it use bzr.exe and not
> bzrw.exe. This was not correcty working, and I have landed a patch for
> this.

Gordon, can you test the latest revno in lp:qbzr/0.19 ?

Gary van der Merwe (garyvdm)
Changed in qbzr:
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
Michael J. Vinca (michaelj) wrote :

Since Alexander asked Gordon to try the latest in 0.19, I decided to give it a try to. Upon attempting a commit I get the following in the message box:

Run command: bzr commit -m "Added Comm Board files from MKS" CmBd_Nonreentrant CmBd_Nonreentrant/CmBdMain CmBd_Nonreentrant/CmBdPsd CmBd_Nonr...
Usage: tbzrcommand.exe [options]

tbzrcommand.exe: error: no such option: --bencode

Revision history for this message
Michael J. Vinca (michaelj) wrote :

Note that my issue is only when qbzr is launched from Tortoise. Launching from Bazaar Explorer does not have the problem. I'm not really sure how that is possible. Ideas?

Revision history for this message
Alexander Belchenko (bialix) wrote :

This is separate bug about tbzrcommand.exe. I'll file a new bug report against TBZR.

Revision history for this message
Alexander Belchenko (bialix) wrote :

It seems that qcommit is invoked via tbzrcommand.exe and not bzr.exe. We may extend the code to detect bzr.exe in the case of Tortoise, but I'd like to check that with Naoki first.

See https://bugs.launchpad.net/tortoisebzr/+bug/641557

Revision history for this message
Alexander Belchenko (bialix) wrote :

Gary van der Merwe пишет:
> ** Changed in: qbzr
> Importance: Undecided => Critical

Gary, IIUC we need to release 0.19.2 with your fix ASAP?

Revision history for this message
methane (songofacandy) wrote :

What version of TortoiseBZR do you use?
I can commit via qcommit via TortoiseBZR.
TortoiseBZR changes sys.argv[0] from 'tbzrcommand(w).exe' to 'bzr(w).exe'.

Revision history for this message
methane (songofacandy) wrote :

I've tested newest qbzr and I can reproduce the bug.
qbzr now looks sys.executable instead of sys.argv[0].
I'll fix it soon and release next TBZR version.

Gary van der Merwe (garyvdm)
Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
status: Confirmed → Fix Committed
Gary van der Merwe (garyvdm)
Changed in qbzr:
milestone: none → 0.19.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.