self.getUserBrowser(user=xxx).open(url) does not fail when the password is wrong
Bug #619049 reported by
Robert Collins
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
William Grant | ||
Bug Description
self.getUserBro
- details:
the password=yyy parameter to getUserBrowser interacts oddly: rather than a 401 or a login redirect, I get the page anonymously - this added great confusion to my testing, because it was entirely nonobvious.
Related branches
lp:~wgrant/launchpad/test-password-everywhere
- Curtis Hovey (community): Approve (code)
-
Diff: 1279 lines (+187/-195)61 files modifieddatabase/sampledata/current-dev.sql (+44/-41)
database/sampledata/current.sql (+44/-41)
lib/lp/answers/stories/project-add-question.txt (+1/-1)
lib/lp/answers/stories/question-add-in-other-languages.txt (+2/-2)
lib/lp/answers/stories/question-edit.txt (+1/-1)
lib/lp/answers/stories/question-search-multiple-languages.txt (+1/-1)
lib/lp/app/stories/form/xx-form-layout.txt (+1/-1)
lib/lp/app/stories/launchpad-root/site-search.txt (+1/-1)
lib/lp/blueprints/stories/blueprints/xx-productseries.txt (+3/-3)
lib/lp/blueprints/stories/sprints/sprint-settopics.txt (+1/-1)
lib/lp/bugs/stories/bug-release-management/xx-bug-release-management.txt (+6/-12)
lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt (+3/-4)
lib/lp/bugs/stories/bugtracker/xx-reschedule-all-watches.txt (+2/-3)
lib/lp/bugs/stories/bugwatches/xx-edit-bugwatch.txt (+2/-3)
lib/lp/code/doc/codereviewcomment.txt (+3/-4)
lib/lp/code/model/tests/test_codereviewcomment.py (+2/-2)
lib/lp/hardwaredb/stories/hwdb/xx-hwdb.txt (+2/-2)
lib/lp/registry/stories/distribution/xx-distribution-launchpad-usage.txt (+1/-1)
lib/lp/registry/stories/distroseries/distroseries-admin.txt (+2/-3)
lib/lp/registry/stories/gpg-coc/xx-gpg-coc.txt (+1/-1)
lib/lp/registry/stories/mailinglists/lifecycle.txt (+1/-1)
lib/lp/registry/stories/mailinglists/subscriptions.txt (+2/-2)
lib/lp/registry/stories/person/xx-add-sshkey.txt (+1/-1)
lib/lp/registry/stories/person/xx-admin-person-review.txt (+2/-3)
lib/lp/registry/stories/person/xx-person-subscriptions.txt (+4/-7)
lib/lp/registry/stories/person/xx-validate-email.txt (+1/-1)
lib/lp/registry/stories/product/xx-product-files.txt (+1/-1)
lib/lp/registry/stories/productrelease/xx-productrelease-basics.txt (+2/-2)
lib/lp/registry/stories/productrelease/xx-productrelease-delete.txt (+1/-1)
lib/lp/registry/stories/project/xx-project-edit.txt (+2/-3)
lib/lp/registry/stories/team-polls/create-poll-options.txt (+1/-1)
lib/lp/registry/stories/team-polls/create-polls.txt (+1/-1)
lib/lp/registry/stories/team-polls/edit-options.txt (+1/-1)
lib/lp/registry/stories/team-polls/edit-poll.txt (+1/-1)
lib/lp/registry/stories/team-polls/vote-poll.txt (+1/-1)
lib/lp/registry/stories/team-polls/xx-poll-confirm-vote.txt (+10/-8)
lib/lp/registry/stories/team/xx-team-membership.txt (+1/-1)
lib/lp/registry/stories/teammembership/private-team.txt (+1/-1)
lib/lp/registry/stories/teammembership/xx-teammembership.txt (+2/-2)
lib/lp/registry/stories/vouchers/xx-voucher-redemption.txt (+1/-1)
lib/lp/registry/tests/test_person.py (+3/-3)
lib/lp/services/feeds/stories/xx-links.txt (+1/-1)
lib/lp/services/oauth/stories/managing-tokens.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-copy-packages.txt (+2/-2)
lib/lp/soyuz/stories/ppa/xx-delete-packages.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-edit-dependencies.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-ppa-navigation.txt (+2/-2)
lib/lp/soyuz/stories/ppa/xx-ppa-packages.txt (+2/-2)
lib/lp/soyuz/stories/ppa/xx-ppa-private-teams.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-ppa-workflow.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-private-ppa-presentation.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-private-ppa-subscription-stories.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-private-ppas.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-builder-page.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-private-builds.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-queue-pages-delayed-copies.txt (+1/-1)
lib/lp/translations/stories/distribution/xx-distribution-translations.txt (+1/-1)
lib/lp/translations/stories/productseries/xx-productseries-export-to-branch.txt (+2/-2)
lib/lp/translations/stories/standalone/xx-pofile-translate-alternative-language.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-sourcepackage-export.txt (+1/-1)
Revision history for this message
| Gary Poster (gary) wrote | #1 |
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #2 |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
getUserBrowser is in lp/testing/