Ctrl-C'ing a push operation == pain

Bug #5987 reported by Brad Bollenbach
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Martin Pool

Bug Description

I was bzr push'ing up a branch. It had taken about 30 minutes and wasn't seeming to do much, so I hit Ctrl-C with the intent to restart the push and see if things turned out better. When I Ctrl-C'd, I got the following output:

Exception exceptions.OSError: <exceptions.OSError instance at 0x30e07e90> in <bound method SFTPFile.__del__ of <paramiko.SFTPFile object at 0x30eb7950>> ignored
bzr: ERROR: exceptions.OSError: [Errno 32] Broken pipe
  at /usr/lib/python2.4/site-packages/bzrlib/transport/sftp.py line 127
  in send
/usr/lib/python2.4/site-packages/bzrlib/branch.py:613: UserWarning: branch BzrBranch('sftp://chinstrap.ubuntu.com/%2Fhome/warthogs/archives/bradb/launchpad/malone-initial-bug-contacts/') was not explicitly unlocked
  warn("branch %r was not explicitly unlocked" % self)
Exception exceptions.OSError: <exceptions.OSError instance at 0x31b71760> in <bound method BzrBranch.__del__ of BzrBranch('sftp://chinstrap.ubuntu.com/%2Fhome/warthogs/archives/bradb/launchpad/malone-initial-bug-contacts/')> ignored

I imagine this output to be quite difficult to read for someone who isn't a Python programmer (or even for somebody who is a Python programmer, but is much more interested in debugging their own error messages, rather than someone else's. :)

I would have preferred some simple output, like:

push operation cancelled.

When I tried the push again, I got this output:

bzr: WARNING: Unable to update the working tree of: sftp://chinstrap.ubuntu.com/%2Fhome/warthogs/archives/bradb/launchpad/malone-initial-bug-contacts/
bzr: ERROR: bzrlib.errors.LockError: File '.bzr/branch-lock' already locked
  at /usr/lib/python2.4/site-packages/bzrlib/transport/sftp.py line 196
  in __init__

I would have expected instead for the push to have resumed where it left off.

Revision history for this message
Robert Collins (lifeless) wrote :

Fix committed to bzr.dev yesterday, It will be in the 0.82rc2 beta.

Changed in bzr:
assignee: nobody → lifeless
status: Unconfirmed → Fix Committed
Changed in bzr:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pool (mbp) wrote :

However this seems to provoke bug #40508

Revision history for this message
Martin Pool (mbp) wrote :

New fix being done by me.

Changed in bzr:
assignee: lifeless → mbp
status: Fix Released → In Progress
Martin Pool (mbp)
Changed in bzr:
status: In Progress → Fix Committed
John A Meinel (jameinel)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.