sourcepackage recipe builds need manifests

Bug #583474 reported by Aaron Bentley
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

Manifests record which revisions of each branch were used in the last build, making them useful for detecting when a branch has changed since the last build.

Sourcepackagerecipe builds generate a manifest file (we think) but this is not handled by Launchpad.

Instead, we should add a database table for recipe manifests and provide a SourcePackageRecipeBuild.manifest as a nullable foreign key.

We will need to customize the handling of BuildBase_handle_status_OK to store manifests

Aaron Bentley (abentley)
description: updated
description: updated
Revision history for this message
Aaron Bentley (abentley) wrote :

We may not actually need a manifest database table. We could just use the manifest to link the appropriate BranchRevisions to the build.

Revision history for this message
William Grant (wgrant) wrote :

IIRC the intention was to use a new SourcePackageRecipeData to store the manifest. It was designed with that in mind.

Revision history for this message
Aaron Bentley (abentley) wrote :

Yes, a SourcePackageRecipeData can store the contents of a manifest, but if we want to store metadata about the manifest, we'll want a table for that.

Unfortunately, a SourcePackageRecipeData stores the revision ids as revision specs, which are not suitable for SQL queries. So if we want to run queries to determine which recipes are stale according to revision ids, we should store Revisions or BranchRevisions.

Aaron Bentley (abentley)
Changed in launchpad-code:
assignee: nobody → Aaron Bentley (abentley)
Aaron Bentley (abentley)
Changed in launchpad-code:
assignee: Aaron Bentley (abentley) → nobody
Revision history for this message
Robert Collins (lifeless) wrote :

@abentely What metadata about manifests is needed?

Changed in launchpad:
importance: Medium → High
tags: added: udd
Revision history for this message
Aaron Bentley (abentley) wrote :

@lifeless The only thing that comes to mind is links to the Revisions that correspond with its "revid:" revision specs.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.