plymouth ubuntu-logo theme script SetY/SetZ typo

Bug #542458 reported by Vishal Rao
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
plymouth (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: plymouth

See http://ubuntuforums.org/showpost.php?p=8997266&postcount=411

"I noticed a possible bug where logo.sprite.SetY is called in the third lines where Alberto Milone probably wanted SetZ which was causing me a little grief! Thats probably why he wrote that draw_logo() function with the comment that "plymouth doesnt seem to draw properly without this" because that function has it set properly"

See line 148 (or there abouts) for "logo.sprite.SetY (logo.z);" as you can see SetY called but setting it to logo.z

ProblemType: Bug
Architecture: amd64
Date: Sat Mar 20 12:32:17 2010
DistroRelease: Ubuntu 10.04
InstallationMedia: Kubuntu 10.04 "Lucid Lynx" - Alpha amd64 (20100112.3)
MachineType: Vishal Rao BlackBird
Package: plymouth 0.8.0~-17
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.32-16-generic root=UUID=5736c9ea-a13e-48cf-a231-7e08e69ae575 ro ipv6.disable=1 quiet splash libata.force=noncq nouveau.modeset=0
ProcEnviron:
 LANGUAGE=
 LANG=C
 SHELL=/bin/bash
ProcFB: 0 EFI VGA
ProcVersionSignature: Ubuntu 2.6.32-16.25-generic
SourcePackage: plymouth
Uname: Linux 2.6.32-16-generic x86_64
dmi.bios.date: 07/15/2009
dmi.bios.vendor: Intel Corp.
dmi.bios.version: DPP3510J.86A.0572.2009.0715.2346
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: DP35DP
dmi.board.vendor: Intel Corporation
dmi.board.version: AAD81073-207
dmi.chassis.asset.tag: 000
dmi.chassis.type: 3
dmi.chassis.vendor: Circle
dmi.chassis.version: cc 715
dmi.modalias: dmi:bvnIntelCorp.:bvrDPP3510J.86A.0572.2009.0715.2346:bd07/15/2009:svnVishalRao:pnBlackBird:pvr001:rvnIntelCorporation:rnDP35DP:rvrAAD81073-207:cvnCircle:ct3:cvrcc715:
dmi.product.name: BlackBird
dmi.product.version: 001
dmi.sys.vendor: Vishal Rao

Related branches

Revision history for this message
Vishal Rao (vishalrao) wrote :
Revision history for this message
Vishal Rao (vishalrao) wrote :

Another thing: Apparently the animate_progress() callback parameters (progress, time) are reversed and it looks like this is an upstream doc bug (if not plymouth bug itself) or just bugs in earlier themes written and floating around causing people to copy the same problem.

By enabling the Debug() line it appears that "progress" is actually the time (in seconds) the splash has been displayed on screen so the other one looks like its the actual progress from 0.0 to 1.0 ...

Revision history for this message
vmc (vmclark) wrote :

@Vishal,
Looking at this: "/lib/plymouth/themes/ubuntu-logo/ubuntu-logo.script"

From line 170:
#-----------------------------------------Logo functions------------------------------

# Call this when updating the screen
fun draw_logo () {
    logo.sprite.SetX (logo.x);
    logo.sprite.SetY (logo.y);
    logo.sprite.SetZ (logo.z);
    logo.sprite.SetOpacity (1);
}

Is that the area your describing?

Revision history for this message
Vishal Rao (vishalrao) wrote : Re: [Bug 542458] Re: plymouth ubuntu-logo theme script SetY/SetZ typo

We could continue this discussion on the forum but yes, that is the
"working" code.
Though the broken code (my guess) is at line 148:

logo.sprite.SetY (logo.z);

And there's a comment line 977 "if a refresh function is not set,
Plymouth doesn't seem to be able to update the screen correctly" but
it may just be due to that earlier typo... :-)

Steve Langasek (vorlon)
Changed in plymouth (Ubuntu):
status: New → Fix Committed
Revision history for this message
Vishal Rao (vishalrao) wrote :

Wow, was the fix already available or did you just now commit it? :-) Where can I see the changelog/commitlog/whatever its called? Thanks a lot...

Revision history for this message
Steve Langasek (vorlon) wrote :

I've committed the fix in response to your bug report. You can see the changelog following the 'related branches' link in the bug report.

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.6 KiB)

This bug was fixed in the package plymouth - 0.8.1-1

---------------
plymouth (0.8.1-1) lucid; urgency=low

  [ Scott James Remnant ]
  * Update to the upstream 0.8.1 release:
    - Our patches have been merged upstream, some changes due to cleaning
      them up for submission and noticing a few bugs along the way.
      Remaining changes are:
      + ubuntu-logo theme
      + ubuntu version of the text theme
      + call update-initramfs rather than plymouth-update-initrd in
        plymouth-set-default-theme
      + filter fsck progress updates from the progress bar tracker
      + watch for enter key press
      + support lbm-nouveau as an alternate driver name for nouveau to
        permit backports once Lucid has released
      + use /dev/fb0 as default framebuffer device name
      + stop animation of script plugin in idle function
    - Will become process group leader of its VT if possible (opens without
      O_NOCTTY when redirecting stdio to it), this is almost certainly
      correct keyboard-wise.
    - Deallocates VT on "plymouth quit" after switching VT back to VT1
    - Open terminal in text and details plugin, don't assume it's already
      open.
    - Calling "plymouth quit" or "plymouth deactivate" while the same
      command is already running will now block the new command until the
      old one complete, rather than returning immediately.
    - Various window fixes for script plugin
    - Script plugin updated to use the window X and Y offsets every time
    - Plymouth client tool has been updated to have commands for many cases
      in preference to the --command style.

  * Restored code to disable Plymouth's graphical plugins when an alternate
    init= is given on the kernel command-line, otherwise init=/bin/bash
    doesn't work so well when Plymouth is in the initramfs.
  * Restored crash handler that dumps boot messages to /dev/tty1.

  * Split themes out into different packages, reducing the size of the
    Plymouth package. This also means that you can remove the themes
    packages to remove the "graphical splash" part of Plymouth while keeping
    the ability to prompt for questions on the console.
  * Use the alternatives system to select the default themes. The existing
    symlink will be replaced on upgrade if you have not changed it.
  * Also use alternatives to select the text theme.
  * Restore the upstream text theme, renaming ours to "ubuntu-text".
  * Fallback to the built-in details theme (boot messages on console, but
    with the ability to prompt for questions) if no theme package is
    installed.
  (LP: #507238)

    Unfortunately these changes mean that if you've selected a custom
    theme, you will need to install that package and select it again.
    Sorry about that.

  * Include the 16-color VGA frame-buffer renderer. LP: #526892.

  * Fix text, ubuntu-text and details themes to restore the console to text
    mode when adding text displays.

  * debian/rules:
    - Set default tty for boot and shutdown with configure arguments
    - Set default background color to the Ubuntu Aubergine, this provides
      some consistency with other default themes.
  * debian/plymouth.upstart, d...

Read more...

Changed in plymouth (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.