[upgrade] mame new upstream 0.138

This is the .debian.tar.gz for the new release 0.138.

To build the package you can either:

- use the get-orig-source target after untarring the debian/ directory
- download the .orig.tar.gz from MAME PPA, where you can also find binaries built for maverick:
   https://edge.launchpad.net/~c.falco/+archive/mame

Waiting for upload... ;)
Cesare.

1. The deprecated_gtk_macros patch failed to apply.
2. The patch didn't have a DEP-3 [1] header. Did you forward the patch to upstream?
3. -0ubuntu0 is useless in the replace field. You should use 0.136u1 instead of 0.136u1-0ubuntu0. Looking at debian/changelog it probably should be 0.136 instead of 0.136u1.
4. Are there plans for getting the man pages upstream?
5. You can remove debian/README.source
6. There are some lintian complains:
E: mame: description-starts-with-package-name
W: mame: games-package-should-be-section-games
I: mame source: duplicate-short-description sdlmame sdlmame-tools
I: mame: extended-description-is-probably-too-short
I: mame-common: extended-description-is-probably-too-short
I: mame: hyphen-used-as-minus-sign usr/share/man/man1/mame.1.gz:913
I: mame-common: package-contains-empty-directory usr/share/doc/mame-common/keymaps/
I: mame: spelling-error-in-binary ./usr/games/mame Continous Continuous
I: mame: spelling-error-in-binary ./usr/games/mame Guage Gauge
I: mame: spelling-error-in-binary ./usr/games/mame Guage Gauge
I: mame: spelling-error-in-binary ./usr/games/mame Independant Independent
I: mame: spelling-error-in-binary ./usr/games/mame Unkown Unknown
I: mame: spelling-error-in-binary ./usr/games/mame Treshold Threshold
I: mame-tools: spelling-error-in-binary ./usr/bin/jedutil succesfully successfully

Some recommendations:
7. Please add a '.patch' suffix to the patches
8. You can use .tar.bz2 instead of .tar.gz (in the get-orig-source rule)
9. You could wrap and sort Build-Depends and Depends in debian/control (makes reading patches easier)

Some suggestions:
10. You could upgrade from debhelper 5 to the short version of debhelper 7 (with the override rules)
11. You could update debian/copyright to use DEP-5 [2]

Please resubscribe ubuntu-sponsors once you have addressed at least the point one till nine.

[1] http://dep.debian.net/deps/dep3/
[2] http://dep.debian.net/deps/dep5/

1. fixed
2. header added; already fixed by upstream maintainer in unstable release 0.138u1
3. fixed
4. patch sent upstream
5. done
6. debian/control changed/updated; also patch with typos fixes sent upstream
7. done
8. done
9. done
10. done
11. This will take time, however it's in my to-do list now ;)

Successfully built on PPA:
https://edge.launchpad.net/~c.falco/+archive/mame/+packages

Here's the debian.tar.gz.

Cheers,
Cesare.

Thanks.

9. It would be nice to have only one entry per line (and not only a line break after 80 characters).
10. I noticed no big change in debian/rules. With dh and the override_* rules the file would be much shorter.
12. Some new lintian complains: To rename a package you should use Break & Replace instead of Conflict & Replace.
I: mame-common: conflicts-with-version sdlmame (<= 0.136)
I: mame-tools: conflicts-with-version sdlmame-tools (<= 0.136)
13. One thing prevents me from uploading the package: Why do you restrict the architectures i386 and amd64? You have cases for powerpc, sparc, hppa, and ia64 in the debian/rules file.

Please resubscribe ubuntu-sponsors (not ubuntu-universe-sponsors) once you have addressed these points.

I've nearly addressed points 9-12, I'm currently stuck with point 13.

Mame should build on any archs, however it has been successfully tested on Intel only;
LPIA would build fine, but the resulting binary would also be unusable due to higher cpu request.
Thus the restriction.

I can both remove references to other archs or allow building for any.
What's your suggestion?

Thanks for your help!
Cesare.

Allow building for any architecture.

Ok, all points are now fixed.

Here's the new .debian.tar.gz, and a build for maverick is available on PPA:
https://edge.launchpad.net/~c.falco/+archive/mame/+packages

Thanks for all your help,
Cesare.

Thanks. I uploaded it with some small changes:
1. Calling dh with "--with quilt" and build depending on quilt is not required due to dpkg-source 3.0 (quilt) format.
2. The dh_override_* rules require debhelper >= 7.0.50~
3. I updated the maintainer field with update-maintainer
4. I removed the "- Closes" before "(LP:"

Ok, thanks.

One thing is puzzling me: I added quilt to build dependencies because of "dh clean --with quilt" failing, unable to find quilt addon.

Has this been solved in debhelper 7.0.50?

Cesare.

The requirement of debhelper 7.0.50 is unrelated to the quilt issue. When using 3.0 (quilt), dpkg-source applies the quilt patches after the extraction. Therefore no build dependency on quilt is required and you don't need to call quilt in debian/rules.