enhancement: sesson/flash save should happen after the plugin afterActionInvocation

Bug #534268 reported by bran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
play framework
Won't Fix
Undecided
Unassigned

Bug Description

the session and Flash restore their state before plugin's beforeActionInvocation(). To keep the symmetry, those two scopes should save() their state after plugin's afterActionInvocation()

so around line 270 in ActionInvoker:

          Scope.Session.current().save();
            Scope.Flash.current().save();

            result.apply(request, response);

            for (PlayPlugin plugin : Play.plugins) {
                plugin.afterActionInvocation();
            }

should probably be switched to

            result.apply(request, response);

            for (PlayPlugin plugin : Play.plugins) {
                plugin.afterActionInvocation();
            }

          Scope.Session.current().save();
           Scope.Flash.current().save();

Changed in play:
status: New → Fix Committed
milestone: none → 1.1
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.