Bazaar Explorer

Custom Switch Dialog Location Error (and speed)

Bug #516957 reported by Dr Al on 2010-02-04

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Bazaar Explorer	Fix Released	High	Neil Martinsen-Burrell

Bug Description

Recent versions of Bazaar Explorer include a custom 'switch' dialog rather than using the QBzr one. There appears to be a couple of bugs in this:

1. It takes noticeably longer to start: on my PC it takes 7 seconds compared with about 1 for the QBzr one (it displays a blank window for a long time).

2. It gets the default location wrong. I've attached two screenshots showing this: custom_switch.png shows the default location with the custom dialog and qbzr_switch.png shows it for the QBzr dialog.

For a checkout of /path/to/project/trunk in directory /other/path/to/working_directory, the default location should be /path/to/project/trunk, not /other/path/to/working_directory.

Related branches

lp:~nmb/bzr-explorer/switch-fix-516957

Merged into lp:bzr-explorer

Ian Clatworthy: Approve on 2010-02-05

lp:bzr-explorer

Revision history for this message

Dr Al (abudden) wrote on 2010-02-04:

Zip file containing screenshots for comparison Edit (11.1 KiB, application/zip)

Revision history for this message

Ian Clatworthy (ian-clatworthy) wrote on 2010-02-04:

Neil,

Can you take a look at the logic error. The speed may not be solvable in the short term?

Changed in bzr-explorer:
assignee:	nobody → Neil Martinsen-Burrell (nmb)

Ian Clatworthy (ian-clatworthy) on 2010-02-04

Changed in bzr-explorer:
importance:	Undecided → High
status:	New → Confirmed

Revision history for this message

Neil Martinsen-Burrell (nmb) wrote on 2010-02-04:

The slowness is from the fact that repository.find_branches is blocking. Gary van de Merwe has a merge proposal for bzr to switch to add an iter_branches capability that could remain responsive (but probably not create the window any fast).

For now, I think we should only monkey with the switch dialog if we are working with a colocated workspace (which means ".bzr/branches" or ".bzrbranches" is in the base). I'll patch to this effect.

Revision history for this message

Ian Clatworthy (ian-clatworthy) wrote on 2010-02-05:

Patched merged. Thanks.