82_rhythmbox-indicators.patch breaks build when libappindicator-dev not available
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
rhythmbox (Ubuntu) |
Invalid
|
Low
|
Ubuntu Desktop Bugs |
Bug Description
Binary package hint: rhythmbox
If I try to build 0.12.6-1ubuntu6 without libappindicator-dev the build breaks:
CCLD libstatus-icon.la
.libs/libstatus
/usr/src/
.libs/libstatus
collect2: ld returned 1 exit status
make[5]: *** [libstatus-icon.la] Error 1
make[5]: Leaving directory `/usr/src/
make[4]: *** [all] Error 2
make[4]: Leaving directory `/usr/src/
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/usr/src/
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/usr/src/
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/src/
make: *** [debian/
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Surely the addition of this patch should not cause a FTBS if one opts not to use libappindicator.
This patch seems to correct the build error. I don't know how well it fits in with the logic of adding the appinidicator though.
--- /tmp/old 2010-01-21 12:49:22.000000000 -0500 patches/ 82_rhythmbox- indicators. patch 2010-01-21 12:42:37.000000000 -0500
+++ debian/
@@ -627,16 +627,18 @@
break;
default:
-@@ -488,6 +507,13 @@
+@@ -488,6 +507,15 @@
return TRUE;
}
++#if defined( HAVE_APP_ INDICATOR) HAVE_NOTIFY) icon_attach_ notification (RBTrayIcon *icon, NotifyNotification *notification) playing_ entry (RBStatusIconPlugin *plugin, gboolean requested)
+#if defined(
+void
+rb_tray_
+{
+}
+#endif
++#endif
+
static void
notify_