82_rhythmbox-indicators.patch breaks build when libappindicator-dev not available

Bug #510778 reported by Brian J. Murrell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rhythmbox (Ubuntu)
Invalid
Low
Ubuntu Desktop Bugs

Bug Description

Binary package hint: rhythmbox

If I try to build 0.12.6-1ubuntu6 without libappindicator-dev the build breaks:

  CCLD libstatus-icon.la
.libs/libstatus_icon_la-rb-tray-icon-gtk.o: In function `rb_tray_icon_attach_notification':
/usr/src/rhythmbox-0.12.6/plugins/status-icon/rb-tray-icon-gtk.c:344: multiple definition of `rb_tray_icon_attach_notification'
.libs/libstatus_icon_la-rb-status-icon-plugin.o:/usr/src/rhythmbox-0.12.6/plugins/status-icon/rb-status-icon-plugin.c:513: first defined here
collect2: ld returned 1 exit status
make[5]: *** [libstatus-icon.la] Error 1
make[5]: Leaving directory `/usr/src/rhythmbox-0.12.6/plugins/status-icon'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/usr/src/rhythmbox-0.12.6/plugins/status-icon'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/usr/src/rhythmbox-0.12.6/plugins'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/usr/src/rhythmbox-0.12.6'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/src/rhythmbox-0.12.6'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Surely the addition of this patch should not cause a FTBS if one opts not to use libappindicator.

Revision history for this message
Brian J. Murrell (brian-interlinx) wrote :

This patch seems to correct the build error. I don't know how well it fits in with the logic of adding the appinidicator though.

--- /tmp/old 2010-01-21 12:49:22.000000000 -0500
+++ debian/patches/82_rhythmbox-indicators.patch 2010-01-21 12:42:37.000000000 -0500
@@ -627,16 +627,18 @@
    break;

   default:
-@@ -488,6 +507,13 @@
+@@ -488,6 +507,15 @@
   return TRUE;
  }

++#if defined(HAVE_APP_INDICATOR)
 +#if defined(HAVE_NOTIFY)
 +void
 +rb_tray_icon_attach_notification (RBTrayIcon *icon, NotifyNotification *notification)
 +{
 +}
 +#endif
++#endif
 +
  static void
  notify_playing_entry (RBStatusIconPlugin *plugin, gboolean requested)

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your bug report but the package has a build-depends on this lib so that's not a bug in ubuntu, you can comment on the bug which was discussing the patch adding though

Changed in rhythmbox (Ubuntu):
assignee: nobody → Ubuntu Desktop Bugs (desktop-bugs)
importance: Undecided → Low
status: New → Invalid
Revision history for this message
Brian J. Murrell (brian-interlinx) wrote :

How do I get even the foggiest clue which bug added this patch?

Revision history for this message
Brian J. Murrell (brian-interlinx) wrote :

NM. I think I found it over in bug 495225. It would have been nice to have just duplicated this bug to that one, or left an indication of the other bug rather than just closing it and leaving me to try to dig up the other bug. In any case, I found it.

Revision history for this message
Sebastien Bacher (seb128) wrote :

sorry about that, usually just look at the debian changelog for such informations

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.