Launchpad itself

Figure out batches in BugWatchUpdater._updateBugTracker()

Bug #509223 reported by Gavin Panella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gavin Panella
Launchpad itself 10.04

Bug Description

We should fill a batch of updates at the earliest possible opportunity, which seems to be early on in _updateBugTracker(), before calling _getExternalBugTrackersAndWatches(). For those external systems that can tell us about modified bugs, we should ask about batch_size number of bugs repeatedly until we have batch_size *modified* bugs.

Related branches

lp:~allenap/launchpad/early-batching-bug-509223
Graham Binns (community): Approve (code)
Diff: 1230 lines (+540/-323)
8 files modified
lib/lp/bugs/doc/checkwatches-cli-switches.txt (+1/-1)
lib/lp/bugs/doc/checkwatches.txt (+6/-6)
lib/lp/bugs/doc/externalbugtracker.txt (+1/-1)
lib/lp/bugs/scripts/checkwatches/__init__.py (+5/-3)
lib/lp/bugs/scripts/checkwatches/base.py (+258/-0)
lib/lp/bugs/scripts/checkwatches/tests/test_base.py (+164/-0)
lib/lp/bugs/scripts/checkwatches/tests/test_updater.py (+3/-24)
lib/lp/bugs/scripts/checkwatches/updater.py (+102/-288)
lp:~allenap/launchpad/early-batching-limit-bug-509223
Brad Crittenden (community): Approve (code)
Diff: 31 lines (+8/-1)
2 files modified
lib/lp/bugs/scripts/checkwatches/updater.py (+5/-1)
lib/lp/bugs/scripts/tests/test_bugimport.py (+3/-0)
lp:~allenap/launchpad/early-batching-bulk-methods-bug-509223
Graham Binns (community): Approve (code)
Diff: 221 lines (+166/-2)
3 files modified
lib/lp/bugs/interfaces/bugwatch.py (+31/-0)
lib/lp/bugs/model/bugwatch.py (+29/-1)
lib/lp/bugs/tests/test_bugwatch.py (+106/-1)
lp:~allenap/launchpad/early-batching-bulk-updates-bug-509223
Abel Deuring (community): Approve (code)
Diff: 318 lines (+93/-89)
5 files modified
lib/lp/bugs/interfaces/bugwatch.py (+4/-4)
lib/lp/bugs/model/bugwatch.py (+38/-23)
lib/lp/bugs/scripts/checkwatches/core.py (+10/-22)
lib/lp/bugs/scripts/tests/test_bugimport.py (+4/-0)
lib/lp/bugs/tests/test_bugwatch.py (+37/-40)
Gavin Panella (allenap)
Changed in malone:
assignee: nobody → Gavin Panella (allenap)
status: Triaged → In Progress
Revision history for this message
Gavin Panella (allenap) wrote :

Causing OOPS-1565CCW1243 for example.

tags: added: oops
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10789 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10789>

Changed in malone:
milestone: none → 10.04
status: In Progress → Fix Committed
tags: added: qa-needstesting
Revision history for this message
Ursula Junque (ursinha) wrote :

Fixed in stable r10816 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10816>

Deryck Hodge (deryck)
tags: added: qa-untestable
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.