checkwatches hammers the remote server when asking for changed bugs
Bug #506158 reported by
Michael Barnett
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Gavin Panella | ||
Bug Description
What happens:
When checkwatches runs it asks the remote server for a list of the bugs that have been updated since a given date (usually the oldest lastchecked date for the current bugwatch set). It does this blindly and doesn't take into account the number of remote bugs its asking about. In the case of gnome-bugs, it was asking about over 13,000 bugs and sending a 52MB POST request to the remote system in order to do so, bringing bugzilla.gnome.org to its knees.
See lib/lp/
What should happen:
checkwatches should be aware of the number of remote bugs its asking about and ensure that it's not an unreasonable number (we could use the current batch size as a guideline, for example).
Related branches
lp:~allenap/launchpad/stop-checkwatches-hammering-bug-506158-devel
- Graham Binns (community): Approve (code)
-
Diff: 225 lines (+168/-17)3 files modifiedlib/lp/bugs/doc/checkwatches-batching.txt (+134/-0)
lib/lp/bugs/doc/externalbugtracker.txt (+3/-0)
lib/lp/bugs/scripts/checkwatches.py (+31/-17)
lp:~allenap/launchpad/stop-checkwatches-hammering-products-bug-506158-devel
- Graham Binns (community): Approve (code)
-
Diff: 112 lines (+28/-7)2 files modifiedlib/lp/bugs/doc/externalbugtracker.txt (+22/-6)
lib/lp/bugs/scripts/checkwatches.py (+6/-1)
| Changed in launchpad: | |
| status: | New → Invalid |
| status: | Invalid → New |
| importance: | Undecided → High |
| affects: | launchpad → malone |
| Changed in malone: | |
| status: | New → Triaged |
| milestone: | none → 10.01 |
| Changed in malone: | |
| assignee: | nobody → Graham Binns (gmb) |
Revision history for this message
| Graham Binns (gmb) wrote | #1 |
| summary: |
- checkwatches being abusive towards external sites + checkwatches hammers the remote server when asking for changed bugs |
| description: | updated |
| description: | updated |
| Changed in malone: | |
| assignee: | Graham Binns (gmb) → nobody |
| Changed in malone: | |
| assignee: | nobody → Gavin Panella (allenap) |
| Changed in malone: | |
| status: | Triaged → In Progress |
Revision history for this message
| Gavin Panella (allenap) wrote | #2 |
Revision history for this message
| Graham Binns (gmb) wrote | #3 |
| Changed in malone: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Gavin Panella (allenap) wrote | #4 |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Do we have any evidence that sites other than gnome-bugs are affected or unaffected? If not then we should just assume that all sites are affected.