Ubuntu Translations

ngettext not used in internationalization of ubuntuone-client

Bug #449269 reported by Daniel Robitaille
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Fix Released
High
dobey
Ubuntu One Client 1.0.0
Ubuntu Translations
Fix Released
Undecided
David Planella
ubuntuone-client (Ubuntu)
Fix Released
Undecided
dobey

Bug Description

On a Karmic system, using the French (Canada) localization, when the Ubuntu One client completes updating one single file, it uses the syntax "1 fichiers" in its pop-up message. This is an incorrect pluralization. "1 fichier" should be used instead.

This is the string:
https://translations.edge.launchpad.net/ubuntu/karmic/+source/ubuntuone-client/+pots/ubuntuone-client/fr/20/+translate

Insteand of gettext function, we should use ngettext for all strings that have both singluar and plural forms

See original description

Related branches

lp:~dobey/ubuntuone-client/ngettext-plurals
Elliot Murphy (community): Approve
Stuart Langridge (community): Approve
Diff: 22 lines
1 file modified
bin/ubuntuone-client-applet (+4/-1)
lp:ubuntu/karmic/ubuntuone-client
Revision history for this message
Daniel Robitaille (robitaille) wrote :
Adi Roiban (adiroiban)
summary: - [Karmic] incorrect french translation in the Ubuntu One client
+ Plural form not used in internationalization of ubuntuone-client
description: updated
summary: - Plural form not used in internationalization of ubuntuone-client
+ ngettext not used in internationalization of ubuntuone-client
dobey (dobey)
Changed in ubuntuone-client:
status: New → In Progress
assignee: nobody → Rodney Dawes (dobey)
milestone: none → w25-karmic-finalfreeze
importance: Undecided → Medium
importance: Medium → High
dobey (dobey)
tags: added: ubuntuone-karmic
dobey (dobey)
Changed in ubuntuone-client:
status: In Progress → Fix Committed
Adi Roiban (adiroiban)
Changed in ubuntu-translations:
status: New → In Progress
assignee: nobody → Adi Roiban (adiroiban)
Revision history for this message
Bruno (bruno666-666) wrote :

Thanks for your bug report Daniel.
As a temporary workaround I've changed French translation to "%total fichier(s)".

dobey (dobey)
Changed in ubuntuone-client:
status: Fix Committed → Fix Released
Joshua Hoover (joshuahoover)
Changed in ubuntuone-client (Ubuntu):
status: New → Triaged
assignee: nobody → Rodney Dawes (dobey)
Revision history for this message
Adi Roiban (adiroiban) wrote :

It looks like the POT files is not generated/updated durring build.

More info about validating translation upload can be found here:
https://wiki.ubuntu.com/UbuntuDevelopment/Internationalisation#Verifying%20translation%20uploads

I have attached the generated translation archive

Revision history for this message
dobey (dobey) wrote :

The use of ngettext is already fixed in the packages. As ubuntuone-client is in main, I believe it's getting translations generated via lang packs, and so the translations are not shipped in ubuntuone-client itself.

Changed in ubuntuone-client (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Adi Roiban (adiroiban) wrote :

Since the ubuntuone-client translation template is not updated in Ubuntu Translation, this problem is not fixed:

Please check the initial report and you will see that it is not fixed:
https://translations.edge.launchpad.net/ubuntu/karmic/+source/ubuntuone-client/+pots/ubuntuone-client/fr/20/+translate

My attached archive is exactly the one generated and used by the lang packs scripts, and since it does not contains any POT file it will not be imported.

Sorry, but we still need more work to fix it in Ubuntu.

Revision history for this message
dobey (dobey) wrote : Re: [Bug 449269] Re: ngettext not used in internationalization of ubuntuone-client

On Wed, 2009-10-14 at 10:41 +0000, Adi Roiban wrote:
> Since the ubuntuone-client translation template is not updated in Ubuntu
> Translation, this problem is not fixed:
>
> Please check the initial report and you will see that it is not fixed:
> https://translations.edge.launchpad.net/ubuntu/karmic/+source/ubuntuone-client/+pots/ubuntuone-client/fr/20/+translate
>
> My attached archive is exactly the one generated and used by the lang
> packs scripts, and since it does not contains any POT file it will not
> be imported.
>
> Sorry, but we still need more work to fix it in Ubuntu.

Understood. However, there's not really anything we can do in
ubuntuone-client to fix that. Not using ngettext, and having correct
translations are also separate issues. The using ngettext issue is
fixed. For the translations issue, it will have to be dealt with by the
translations/release teams, to get the language pack rebuilt and updated
appropriately. Even if I stuck the translations in the ubuntuone-client,
they would get stripped in packaging, by the langpack generation
scripts, in favor of the translations being distributed via langpacks.

Revision history for this message
David Planella (dpm) wrote :

I agree that these are two separate issues. The ngettext bug seems to have been fixed as per this report. For the issue with the template not being imported, I've filed bug 455527

Adi Roiban (adiroiban)
Changed in ubuntu-translations:
status: In Progress → Fix Released
David Planella (dpm)
Changed in ubuntu-translations:
assignee: Adi Roiban (adiroiban) → David Planella (dpm)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.