GTG

Starting GTG starts Tomboy when tb plugins is disabled

Bug #448114 reported by Bertrand Rousseau
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
GTG
Fix Released
High
Luca Invernizzi

Bug Description

1/ Launch GTG 0.1.2-dev (with tomboy plugin included)
2/ Disable tomboy plugin
3/ quit Tomboy
4/ Launch GTG again
5/ Tomboy is started!

Tags: plugins tomboy
Revision history for this message
Luca Invernizzi (invernizzi) wrote :

That's true. In fact, I already signaled that in bug #442284 (comment 5^).
The problem is caused because this plugin has a dependency on tomboy (via dbus). Therefore, Paulo's plugin system checks if tomboy is available on the system, by querying dbus. Unfortunately, Tomboy is started, if not running, when its name is queried in dbus.
However, it's a decision of Tomboy developers, so we have to choose between two things:
- we could file a bug about that
- we could remove tomboy dependency (via dbus).
If we choose the second option, the plugin will notice that tomboy is not installed and therefore won't do anything (which is correct). However, the plugin would be activable also if tomboy is not present (which is against what Lionel said in #442284, comment #3).
Please comment on what I should do.

PS: I'm going to take a very long flight (33h), so I won't answer in the next two days at least

Revision history for this message
Luca Invernizzi (invernizzi) wrote :

Any idea on this?

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote : Re: [Bug 448114] Re: Starting GTG starts Tomboy when tb plugins is disabled

In my view, it's a tomboy bug: we should be able to ask for the presence of
tomboy without starting it, it's a different action. However, it's up to
them.

My take is that is not acceptable to launch tomboy when GTG is starting.
It's confusing and it slows down the startup of GTG. Maybe you should speak
with Paulo to look for a workaround.

On Fri, Oct 16, 2009 at 6:13 AM, Luca Invernizzi <email address hidden>wrote:

> Any idea on this?
>
> --
> Starting GTG starts Tomboy when tb plugins is disabled
> https://bugs.launchpad.net/bugs/448114
> You received this bug notification because you are a direct subscriber
> of the bug.
>

--
Bertrand Rousseau
Rue Victor Horta, 31/202 1348 Louvain-la-Neuve, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

Revision history for this message
Luca Invernizzi (invernizzi) wrote :

I've pushed a fix that shows a decent behaviour in any case: if tomboy is installed is fine, otherwise one can activate the plugin, but then it will complain that tomboy is not installed and ask for deactivation (just once every gtg session). I'll ask paulo if I can have a dependency over a file, that should fix it.

(branch ~gtg-users/gtg/tomboy, revision 351)

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Marking as high. If this bug is not fixed, we cannot ship Tomboy plugin with 0.2. BTW, does it works with Gnote ? (Tomboy clone in C++)

Changed in gtg:
importance: Medium → High
Revision history for this message
Luca Invernizzi (invernizzi) wrote :

Gnote does not provide dbus, thus it does not work with gnote.
Currently the behaviour is correct, apart from the fact that it lets you activate the plugin if you have tomboy installed and then it warns you. I've asked Paulo to add a dependency over a file: he will as soon as he has some free time. Please try that revision and tell me what you think of it. I'd say that now it's not such a critical bug anymore.

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Thanks for the quick fix Luca. I understand how frustrating it is to commit such a fix ;-)

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

BTW, is the bug reported to Tomboy ?

Changed in gtg:
status: Confirmed → Fix Committed
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.