Remove owner permissions check from POTemplate.newPOFile

Bug #443129 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Jeroen T. Vermeulen

Bug Description

POFiles are created through POTemplate.newPOFile. This method checks whether the person creating the POFile would have editing permissions on it. If so, the requester becomes the owner. If not, rosetta_admins becomes the owner.

This triggers a permissions check that has tripped up us several times on database permissions for rarer cases. It'd be more transparent if this check were done at the call site.

Moreover, POFile.owner doesn't seem to be used for anything meaningful, so we may not need it at all. The only thing it seems to do is give the owner editing permissions—which in the current code they must have had anyway to have become the owner in the first place. We could drop it, or allow it to be NULL and make that the default.

Related branches

Changed in rosetta:
status: New → Triaged
importance: Undecided → Low
tags: added: tech-debt
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

The approver is currently failing again because of this: bug 487590.

Changed in rosetta:
importance: Low → Medium
assignee: nobody → Jeroen T. Vermeulen (jtv)
milestone: none → 3.1.11
Changed in rosetta:
status: Triaged → In Progress
Revision history for this message
Ursula Junque (ursinha) wrote : A commit mentioned this bug
Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
tags: added: qa-ok
removed: qa-needstesting
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.