GTG

tags colors don't use default colour from theme

Bug #429743 reported by Luca Invernizzi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
Medium
Bertrand Rousseau
GTG 0.2 "Gorignak"

Bug Description

This causes gtg tags colors unusable in dark themes. Since ubuntu ships with some dark themes, it may be annoying. Screenshot attached

Revision history for this message
Luca Invernizzi (invernizzi) wrote :
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Maybe this could be an easy fix so I assign this to 0.2 (because it would be really bad to no support dark themes). I think we only have to change the code of the colour generator. If too complicated, report it to 0.3

Changed in gtg:
milestone: none → 0.2
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

To reproduce in Ubuntu Karmic :

sudo apt-get install gnome-themes-extras

then switch them to darklooks and enable color in GTG > view.

We should take into account the color of the theme when computing the color of the background

Changed in gtg:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

Fixed this bug in revno 441. Attached screenshot to see results. Background color is now specified by an alpha value. Value of 0.5 seems fine for me, but It might some adjustment if people prefer so.

Changed in gtg:
status: Confirmed → Fix Committed
assignee: nobody → Bertrand Rousseau (bertrand-rousseau)
Revision history for this message
Kevin Mehall (kevin-mehall) wrote :

IMHO r441 makes the colors way too dark (saturated) on a light theme. I don't think alpha is the answer because some tag colors are light while others are dark. The old algorithm evened out the brightness.

I wrote a version that makes alpha proportional to the difference in brightness.
https://code.launchpad.net/~kevin-mehall/gtg/color-algorithm

Luca Falavigna (dktrkranz)
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.