Merge proposals need a "Withdraw proposal" action

Bug #419323 reported by John A Meinel
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

So if you go to a merge proposal and say "resubmit", then it will mark the current merge proposal as superseded by another merge proposal from the same branch.

However, is there a way to say "oh, my proposal is actually superseded by this other *already existing* merge proposal". Which may be from someone else and a different branch.

My specific case was that I meant to target an MP to a release branch rather than trunk, and ended up with 2 proposals. I'd like a way to cleanly close one of them.

Tags: lp-code
Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 419323] [NEW] code review Is there a way to say this mp is superseded by another mp?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:
> Public bug reported:

> My specific case was that I meant to target an MP to a release branch
> rather than trunk, and ended up with 2 proposals. I'd like a way to
> cleanly close one of them.

In our current thinking, your proposal to merge into a release branch is
a different thing from your proposal to merge into trunk. The outcome,
if approved, would be substantially different. I don't think
"superseded" would make sense here.

I can quite well imagine that a proposal to merge X into Y could be
superseded by a proposal to merge Z into Y, though. And I can see you
might want to re-target a proposal to a release branch instead of trunk.
 What do you think?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqVad4ACgkQ0F+nu1YWqI1XJwCfYGrJiXQv/DA1HtPcWtiXm6XW
o3QAmwTrIcd+OK7E/+VMndtoA0HDxKZk
=r8EM
-----END PGP SIGNATURE-----

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John A Meinel wrote:
>> Public bug reported:
>
>> My specific case was that I meant to target an MP to a release branch
>> rather than trunk, and ended up with 2 proposals. I'd like a way to
>> cleanly close one of them.
>
> In our current thinking, your proposal to merge into a release branch is
> a different thing from your proposal to merge into trunk. The outcome,
> if approved, would be substantially different. I don't think
> "superseded" would make sense here.
>
> I can quite well imagine that a proposal to merge X into Y could be
> superseded by a proposal to merge Z into Y, though. And I can see you
> might want to re-target a proposal to a release branch instead of trunk.
> What do you think?
>
> Aaron

So I won't say that all proposals to release supersede proposals to
merge to trunk. I mostly wanted a way to close my proposal in a clean
way, as I didn't mean to make it.

1) Being able to retarget it would have been ok, though slightly
problematic if I've already submitted a new request and just want to
close the old one out graciously.

2) Being able to say that someone else's work is better than your own
would also be useful (independent of my current use case.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqVbBIACgkQJdeBCYSNAAP5EgCbBBNAqaE3pq2st9ijEauE7g2x
TfcAoInKyAlfzhuZulxlk+5O0AoL91AI
=RTS9
-----END PGP SIGNATURE-----

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:
> Aaron Bentley wrote:
>> I can quite well imagine that a proposal to merge X into Y could be
>> superseded by a proposal to merge Z into Y, though. And I can see you
>> might want to re-target a proposal to a release branch instead of trunk.
>> What do you think?

> So I won't say that all proposals to release supersede proposals to
> merge to trunk.

That's not something I proposed, and not something I thought you were
proposing. What do you mean?

> I mostly wanted a way to close my proposal in a clean
> way, as I didn't mean to make it.

We are planning to add a "withdraw" action on branch merge proposals so
that their submitter can withdraw them. Would that seem right in this case?

> 1) Being able to retarget it would have been ok, though slightly
> problematic if I've already submitted a new request and just want to
> close the old one out graciously.

I think that's the sort of corner case that's never going to be perfect.
 But you could delete the new one and retarget the old one. Or delete
the old one if it didn't get used.

> 2) Being able to say that someone else's work is better than your own
> would also be useful (independent of my current use case.)

Cool.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqVco0ACgkQ0F+nu1YWqI1tBACeLSofwdHZHdMJcUis2/ZVDZ1o
kgEAn3wtM7VuNnmndU4WZbbNIfOVW8nA
=+T4+
-----END PGP SIGNATURE-----

Paul Hummer (rockstar)
summary: - code review Is there a way to say this mp is superseded by another mp?
+ Merge proposals need a "Withdraw proposal action"
summary: - Merge proposals need a "Withdraw proposal action"
+ Merge proposals need a "Withdraw proposal" action
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.