GTG

Convert core .glade files to GtkBuilder

Bug #412582 reported by Bertrand Rousseau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
High
Bertrand Rousseau
GTG 0.2 "Gorignak"

Bug Description

Yes guys, at some points we will be obliged to do so.

References:
 - http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder

Tags: refactoring ui
Bertrand Rousseau (bertrand-rousseau)
Changed in gtg:
milestone: none → 0.3
status: New → Confirmed
importance: Undecided → Low
Lionel Dricot (ploum-deactivatedaccount)
Changed in gtg:
importance: Low → High
assignee: nobody → Bertrand Rousseau (bertrand-rousseau)
Bertrand Rousseau (bertrand-rousseau)
summary: - Convert .glade files to GtkBuilder
+ Convert core .glade files to GtkBuilder
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

isn't that fixed in trunk? Should it be assigned to 0.2? Did you find your answers for the missing handlers?

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

Nope, there's still warnings. This is why this bug is still not closed. I'll move to 0.2 since we can clearly fix this quickly.

Here are the warnings:

/home/rousseau/workspace/gtg/working/GTG/taskeditor/editor.py:94: RuntimeWarning: missing handler 'on_focus_out'
  self.builder.connect_signals(dic)
/home/rousseau/workspace/gtg/working/GTG/taskeditor/editor.py:94: RuntimeWarning: missing handler 'on_dayselected'
  self.builder.connect_signals(dic)
/home/rousseau/workspace/gtg/working/GTG/taskeditor/editor.py:94: RuntimeWarning: missing handler 'on_month_changed'
  self.builder.connect_signals(dic)
/home/rousseau/workspace/gtg/working/GTG/taskeditor/editor.py:94: RuntimeWarning: missing handler 'on_inserttag_show_menu'
  self.builder.connect_signals(dic)

Could you have a look at this? We need to decide if the handler is still relevant or not. If it is, then it should be properly assigned using the callback dictionary. If it is not, then the handler should be removed from the GtkBuilder file using Glade.

Changed in gtg:
milestone: 0.3 → 0.2
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Those signals have no handler for a while now (3 of them are left from my experimentations with the date selector widget).

They are now removed in rev. 371

Changed in gtg:
status: Confirmed → Fix Committed
Luca Falavigna (dktrkranz)
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.