GTG

Incorrect behaviour marking a dismissed task as done

Bug #406851 reported by Patrick Coleman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
High
Patrick Coleman

Bug Description

If you open a dismissed task and click the 'Mark as done' button, the task is undismissed rather than marked as done.

To reproduce:
- Create a task
- Click dismiss
- Edit the dismissed task
- Click 'mark as done'

Expected behaviour: Task editor should disappear, task should be undismissed and marked as done
Actual behaviour: Task is undismissed, editor window does not disappear

Related branches

Changed in gtg:
importance: Undecided → High
milestone: none → 0.2
status: New → Confirmed
Revision history for this message
Patrick Coleman (blinken) wrote :
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

solved in rev. 296

Changed in gtg:
assignee: nobody → Lionel Dricot (ploum)
status: Confirmed → Fix Committed
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Midair colision. Sorry Patrick, I solved that without knowing you were working on this.

Anyway, if you feel that you're code is cleaner than my quickfix, there's no problem with merging your fix instead of mine.

Revision history for this message
Patrick Coleman (blinken) wrote :

Heh. Wasn't going to fix it, but was scrolling past and saw it was a quick job. Merge is up to you; I cleaned up dismiss() for clarity while I was at it, so feel free to cherrypick that or merge the whole lot, whichever works.

Revision history for this message
Patrick Coleman (blinken) wrote :
Changed in gtg:
assignee: Lionel Dricot (ploum) → Patrick Coleman (blinken)
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.