GTG

Requester.get_used_tags should return only tags used on active and visible tasks

Bug #398645 reported by Jonathan Lange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
Low
Unassigned

Bug Description

Requester.get_used_tags currently returns every tag ever used. It should return only tags used on active and visible tasks.

Filed based on the comment in Requester.get_used_tags.

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

Currently, get_used_tags() is not used following this definition in the browser. Could someone confirm the right definition of the function (ploum?), so that we can fix things accordingly?

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

This looks clearly related with the get_all_tags bug. I should investigate this a bit more.

Changed in gtg:
assignee: nobody → Lionel Dricot (ploum)
importance: Undecided → Low
milestone: none → 0.2
status: New → Confirmed
Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote : Re: [Bug 398645] Re: Requester.get_used_tags should return only tags used on active and visible tasks

I thinks it's actually used to display a list of available tags in the
browser and editor, without showing unused ones so that we do not
clutter the UI. Right now get_used_tags return all tags ever been
used, and they are filtered afterward by calculating how many active
tasks are related.

My take is that the filtering should indeed been done directly in get_used_tags.

On Wed, Jul 15, 2009 at 9:20 AM, Lionel Dricot<email address hidden> wrote:
> This looks clearly related with the get_all_tags bug. I should
> investigate this a bit more.
>
> ** Changed in: gtg
>   Importance: Undecided => Low
>
> ** Changed in: gtg
>       Status: New => Confirmed
>
> ** Changed in: gtg
>    Milestone: None => 0.2
>
> ** Changed in: gtg
>     Assignee: (unassigned) => Lionel Dricot (ploum)
>
> --
> Requester.get_used_tags should return only tags used on active and visible tasks
> https://bugs.launchpad.net/bugs/398645
> You received this bug notification because you are a member of Gtg
> developers, which is the registrant for Getting Things GNOME!.
>
> Status in Getting Things GNOME!: Confirmed
>
> Bug description:
> Requester.get_used_tags currently returns every tag ever used. It should return only tags used on active and visible tasks.
>
> Filed based on the comment in Requester.get_used_tags.
>

--
Bertrand Rousseau
Place communale 1, 1450 Chastre, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Fixed in rev. 289

Changed in gtg:
status: Confirmed → Fix Committed
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.