GTG

returnlist reimplements copy.deepcopy

Bug #398360 reported by Jonathan Lange on 2009-07-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	GTG	Fix Released	Wishlist	Jonathan Lange	GTG 0.2 "Gorignak"

Bug Description

The comment before returnlist() says:
#Return a copy of the list and avoid a to keep the same object
#It handles multilple dimension matrix through recursion

(Incidentally, shouldn't that be a docstring?)

Python already comes with a way to do this. It's called 'deepcopy' and it's in the 'copy' module of the standard library.

Tags:

Related branches

lp:~jml/gtg/deepcopy-398360

Merged into lp:~gtg/gtg/old-trunk

Gtg developers: Pending requested 2009-07-12

lp:~jml/gtg/returnlist-to-list

Merged into lp:~gtg/gtg/old-trunk

Gtg developers: Pending requested 2009-07-13

Revision history for this message

Jonathan Lange (jml) wrote on 2009-07-12:

I've submitted a patch for this.

Changed in gtg:
assignee:	nobody → Jonathan Lange (jml)
status:	New → In Progress

Revision history for this message

Lionel Dricot (ploum-deactivatedaccount) wrote on 2009-07-13:

I've undoed your merge for this as it causes some trouble (heavy crashes).

TypeError: instancemethod expected at least 2 arguments, got 0
Traceback (most recent call last):
  File "/home/ploum/gtg/GTG/taskbrowser/browser.py", line 768, in refresh_tb
    self.refresh_list(toselect=toselect)
  File "/home/ploum/gtg/GTG/taskbrowser/browser.py", line 877, in refresh_list
    treeview=False)
  File "/home/ploum/gtg/GTG/taskbrowser/browser.py", line 1007, in add_task_tree_to_list
    tags = task.get_tags()
  File "/home/ploum/gtg/GTG/core/task.py", line 401, in get_tags
    return deepcopy(self.tags)
  File "/usr/lib/python2.6/copy.py", line 162, in deepcopy
    y = copier(x, memo)

It looks like our own implementation is more robust.

Maybe, using deepcopy uncovered a bug in GTG. If this is the case, then I would suggest to make thing easier by only calling deepcopy in the returnlist function, allowing easy change for developpers.