Branch.cleanup() re-creates the checkout

Bug #397478 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tarmac
Fix Released
Critical
Paul Hummer

Bug Description

The Branch.cleanup() function is implemented as:

if self.has_tree:
  self._set_up_working_tree():

However, _set_up_working_tree does:

        if os.path.exists(self.temporary_dir):
            shutil.rmtree(self.temporary_dir)
        self.tree = self.branch.create_checkout(self.temporary_dir)

In other words, Branch.cleanup() *will* delete the existing target, but then it will re download the whole thing and re-create it.

See also bug #397476, fixing that would at least make this less expensive, even if it is still wrong :)

Paul Hummer (rockstar)
Changed in tarmac:
assignee: nobody → Paul Hummer (rockstar)
importance: Undecided → Critical
milestone: none → tarmac-0.2
status: New → Triaged
Paul Hummer (rockstar)
Changed in tarmac:
status: Triaged → In Progress
Paul Hummer (rockstar)
Changed in tarmac:
status: In Progress → Fix Committed
Paul Hummer (rockstar)
Changed in tarmac:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.