notify-osd changes the way it supports int32-hints

Bug #390669 reported by Ken VanDine
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-power-manager (Ubuntu)
Triaged
Low
Unassigned

Bug Description

Binary package hint: gnome-power-manager

The way notify-osd treats int32-hints passed to it has changed. The net result of this is that the UI-behaviour of the
feedback-notifications (Volume Up/Down, Screen-Brightness Up/Down, Keyboard-Brightness Up/Down) works now correctly with under- and overshoot throbbing.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Patch from Mirco Müller

Changed in gnome-power-manager (Ubuntu):
assignee: nobody → Ken VanDine (ken-vandine)
Revision history for this message
Scott Howard (showard314) wrote :

Hey Ken, are you still working on the patch or has it been tested and is ready for merging?

Changed in gnome-power-manager (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Scott Howard (showard314) wrote :

added the bzr branch for this fix.

Changed in gnome-power-manager (Ubuntu):
assignee: Ken VanDine (ken-vandine) → nobody
Revision history for this message
Scott Howard (showard314) wrote :

to the sponsors: the patch was written by Mirco Müller, can you see that he gets the proper credit in the changelog? Thanks!

Revision history for this message
Scott Howard (showard314) wrote :

wait a sec, there is a build error - i'll send an updated one

Revision history for this message
Scott Howard (showard314) wrote :

I'd like to remove ubuntu-main-sponsors, there are problems with the patch. The patch is against 2.27.1, and the newest release is 2.27.2

I was able to update the patch for all except the 8th hunk (gpm.manager.c, which is now the 7th hunk in this updated patch file). I cannot find where the addition is supposed to be made. Can you please update that hunk against 2.27.2? Thanks.

Revision history for this message
Scott Howard (showard314) wrote :

(the above patch is with my updates for 2.27.2)

Revision history for this message
Scott Howard (showard314) wrote :

Sorry for the extra emails, but I think I found the problem:

Version 2.27.2 eliminated keyboard backlight brightness support:
http://git.gnome.org/cgit/gnome-power-manager/commit/?id=c8a560caf488129c03a4e437ff7bd54f173c2f55
"Remove ambient light sensor support, and keyboard backlight devices"

brightness_kbd_changed_cb is no longer a function in GPM.

Next step: refresh the above patch (comment 6) for 2.27.2 and remove the final hunk.

Changed in gnome-power-manager (Ubuntu):
assignee: nobody → Scott Howard (showard314)
status: Triaged → In Progress
Revision history for this message
Scott Howard (showard314) wrote :

See attached branch, ready for merge.

Renamed file to match Martin Pitt's most recent commits. Added the description tag Martin added, and refreshed Mirco Muller's patch for 2.27.2. Keyboard brightness support had been dropped in 2.27.2, so that part of Mirco's original patch had been dropped along with the section:
/* display the widget when something else changed the backlight */
in brightness_changed_cb gpm-backlight.c since GPM no longer calls:
gpm_feedback_display_value (backlight->priv->feedback, (float) percentage / 100.0f);
in that function.

Changed in gnome-power-manager (Ubuntu):
assignee: Scott Howard (showard314) → nobody
status: In Progress → Triaged
Revision history for this message
Scott Howard (showard314) wrote :

To clean up the bug reports, I'm duplicating this bug with bug 406396. This has the added benefit of take it off of the main-sponsors list.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.