code review does not set X-Launchpad-Notification-Type for initial request

Bug #388679 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Tim Penhey

Bug Description

I'm trying to filter my code review requests into a separate folder. I looked at some of the headers when I submitted a comment on a review. And I saw these headers:

X-Launchpad-Message-Rationale: Owner
X-Launchpad-Notification-Type: code-review
X-Launchpad-Branch: ~jameinel/bzr/1.16-simple-win32
In-Reply-To: <email address hidden>
Reply-To: <email address hidden>
Message-Id: <email address hidden>
X-Launchpad-Project: bzr

I noticed the "Notification-Type" which seemed like a nice header to use to distinguish other emails (like bug reports, etc). However, when I went to submit a new branch for review, the headers were:

X-Launchpad-Project: bzr
Reply-To: <email address hidden>
Message-Id: <email address hidden>
X-Launchpad-Message-Rationale: Owner
X-Launchpad-Branch: ~jameinel/bzr/1.17-extract-one-time

oddly, it still has some of the headers like Rationale, and the Branch. But no indication of code-review.

The only header I have to go on is that "Reply-To" ~= mp.*@code.launchpad.net

It would be really nice to have something clear.

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 388679] [NEW] code review does not set X-Launchpad-Notification-Type for initial request

On Thu, 18 Jun 2009 09:16:58 John A Meinel wrote:
> Public bug reported:
>
> I'm trying to filter my code review requests into a separate folder. I
> looked at some of the headers when I submitted a comment on a review.
> And I saw these headers:
>
> X-Launchpad-Message-Rationale: Owner
> X-Launchpad-Notification-Type: code-review
> X-Launchpad-Branch: ~jameinel/bzr/1.16-simple-win32
> In-Reply-To:
> <email address hidden> Reply-To:
> <email address hidden>
> Message-Id: <email address hidden>
> X-Launchpad-Project: bzr
>
> I noticed the "Notification-Type" which seemed like a nice header to use
> to distinguish other emails (like bug reports, etc). However, when I
> went to submit a new branch for review, the headers were:
>
> X-Launchpad-Project: bzr
> Reply-To: <email address hidden>
> Message-Id: <email address hidden>
> X-Launchpad-Message-Rationale: Owner
> X-Launchpad-Branch: ~jameinel/bzr/1.17-extract-one-time
>
> oddly, it still has some of the headers like Rationale, and the Branch.
> But no indication of code-review.
>
> The only header I have to go on is that "Reply-To" ~=
> mp.*@code.launchpad.net

It will be there once we roll out 2.2.6, but since this email is not generated
by the appservers, it doesn't have the edge code.

Jonathan Lange (jml)
Changed in launchpad-code:
assignee: nobody → Tim Penhey (thumper)
milestone: none → 2.2.6
status: New → Fix Committed
Tim Penhey (thumper)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.