"Do not disconnect" and "ok to disconnect" device notifications should not use the same icon

I agree but to add:
Pop-up for displaying writing to disk should not disappear until writing finishes (sometimes I have wondered off and had to manually verify if the device is still busy).

+1
I would add: "ok to disconnect" should appear in any case, even if no writes are needed (on my system it doesn't happen).

Why not use the new notifications? Very simple and beautiful

Make the pop-up a floating windows without focus. OK to disconnect window should be shown as suggested by Alessio.
The window shouldn't have any buttons and should be closed by using the window decoration button (direct user interaction) or should close automatically when the user removes the drive (indirect user interaction).
Maybe add the minimize button so if the write is long the user can minimize the windows to the window list. Upon write completion the window should either pop-up or flash in the window list.

Any other suggestions?

Disclaimer: Not at my Ubuntu box so I'm just guessing that this isn't already implemented in some way.

I agree with Nicolas' idea. Why not incorporate it into a notification system already in use rather than maintaining a separate, independent process just for this?
I also have to add that these notifications do not always appear 100% of the time or me. I would estimate that about 30% of the time I get no other indication that it's safe to remove the USB drive than the icon disappearing in the Nautilus sidebar. But that should probably be filed as it's own bug.

@John Montgomery:
There is already separate bug for that > Bug #386057

I'm with Nicholas and John. "Safe to remove disk" should be an OSD notification. The "Wait to remove" notification should clearly show a different icon with a red X or a crossed circle in front of a usb symbol. The "Safe to remove" one should have a green check mark and an arrow indicating pulling out the plug.

Since we do not have a "Safely unmount all partitions to remove $DEVICE_NAME" option in gnome, Bug #387512 is crucial to fix, so that the notifications are shown every time it is safe to remove a device.

Sorry, Bug #387512 is a duplicate. I meant Bug #386057 is crucial to fix along with this one.

I think the real fix for this is to use notify-osd for these, with proper icons, which I think belongs in gvfs.

GVFS doesn't even link to libnotify and is in no way responsible for sending notifications anywhere. This is coming from somewhere even lower in the stack.

Assigning this to gnome-disk-utility since it is the application responsible for the notifications.

Notification bubbles are not a "notification system", they are just one notification mechanism. See <https://wiki.ubuntu.com/NotificationDesignGuidelines> for an overview of other mechanisms.

gnome-disk-utility used to use a notification bubble for this situation. But with Notify OSD, when a bubble disappeared, the unmounting wouldn't necessarily have finished yet. So we fixed gnome-disk-utility to use a progress window instead, as it really should have in the first place. (After all, other kinds of file moving and copying use a progress window.)

From the design specification for the progress window <https://wiki.ubuntu.com/NotifyOSD#gnome-disk-utility>: "The title and icon for the progress window should be the name and icon for the volume." For that reason, in the absence of an explanation for why it should change icons part-way through, I'm closing this bug report.

If there are indeed "two popups" instead of one, please report a separate papercut about that. And if the window sometimes doesn't appear at all, please report a separate papercut about that. Either of those situations could have made it seem as if two separate icons should be used.