Last download time still sucks

Bug #385810 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Guilherme Salgado

Bug Description

Since bug #384783 was fixed, files downloaded today say "last downloaded today", which is good.

However, files downloaded yesterday say "24 hours since last download", and those downloaded earlier say "six days since last download". The former is too specific, and both suffer from having the time at the opposite end to "last downloaded today".

Since I can't think of a way to get the "today" to the front, I suspect the others should be moved to the end - something like "last downloaded yesterday" or "last downloaded two days ago".

Tags: lp-registry
Revision history for this message
Curtis Hovey (sinzui) wrote :

Salgado, do you think you can improve this before the freeze? if so target it to this milestone, otherwise, unassign yourself.

Changed in launchpad-registry:
assignee: nobody → Guilherme Salgado (salgado)
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Guilherme Salgado (salgado) wrote :

It's easy to change it to always say 'last downloaded {today|some time ago}', but the code we're using to convert a timedelta into a meaningful string is what's responsible for the '24 hours' bit, and that code is used in tons of other places and behaves just like it was intended to [1], so I'll do the easy change now and leave the other for later.

[1] https://launchpad.canonical.com/PresentingLengthsOfTime

Changed in launchpad-registry:
status: Triaged → In Progress
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Guilherme Salgado (salgado) wrote :

r8641

Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 2.2.6
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 385810 Fix released

Fixed released in Launchpad 2.2.6.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.