Launchpad itself

XPI files fail to import

Bug #385630 reported by Данило Шеган
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jeroen T. Vermeulen
Launchpad itself 2.2.6

Bug Description

As can be seen on https://translations.edge.launchpad.net/ubuntu/jaunty/+source/firefox-3.0/+imports Launchpad has been unable to import XPI files for some time now already.

Logged error is:

"jar:chrome/cy.jar!/locale/browser/netError.dtd: Couldn't open resource 'chrome://branding/locale/brand.dtd'"

I've tried with XPIs from 3.0.7 (https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/3.0.7/linux-i686/xpi/) and they don't import either.

Why this didn't cause problems previously, and causes them now is to be investigated.

Revision history for this message
Данило Шеган (danilo) wrote :

Would be nice to figure this out for 2.2.6.

Changed in rosetta:
importance: Undecided → High
milestone: none → 2.2.6
status: New → Triaged
Revision history for this message
Данило Шеган (danilo) wrote :
Revision history for this message
Данило Шеган (danilo) wrote :

FWIW, this all worked in r8000 and r7600, and the full diff between r8000 and r8566 for XPI files is:
  https://pastebin.canonical.com/18218/

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

This is fallout from a pretty old change: we used to ignore any and all parsing errors in XPI files, and we don't any more. We also improved the reporting of errors in several ways since then, which is probably why the problem took so long to become visible enough.

At first glance, I'd say the fix is probably to call DTDParser.set_inputsource_factory to substitute a custom factory. That's also a first step on the way for another improvement that asac has long been waiting for.

Jeroen T. Vermeulen (jtv)
Changed in rosetta:
assignee: nobody → Jeroen T. Vermeulen (jtv)
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Putting fix up for review.

Changed in rosetta:
status: Triaged → In Progress
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Fixed in devel 8626 (merged in db-devel 8162).

Changed in rosetta:
status: In Progress → Fix Committed
Jeroen T. Vermeulen (jtv)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.