Launchpad itself

Cannot review

Bug #337795 reported by Francis J. Lacoste
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Aaron Bentley
Launchpad itself 2.2.6

Bug Description

According to https://help.launchpad.net/Code/Review

"Once you've proposed a merge, anyone who has a Launchpad account can comment and vote on the proposal. Taking part in a code review is virtually hassle-free"

That doesn't seem to be true:

https://code.edge.launchpad.net/~leonardr/lazr.uri/cleanup/+merge/4140

I cannot vote or review that merge proposal. I have no idea why.

I could only add a reply.

Jonathan Lange (jml)
Changed in launchpad-bazaar:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

This is a documentation bug.

Only the branch owner or member of the default review team can review.

Revision history for this message
Martin Albisetti (beuno) wrote :

This is probably due to the fact that we changed the behavior with Tim during our sprint :)

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 337795] Re: Cannot review

On Thu, 05 Mar 2009 09:51:44 Martin Albisetti wrote:
> This is probably due to the fact that we changed the behavior with Tim
> during our sprint :)

I blame beuno.

Revision history for this message
Jonathan Lange (jml) wrote :

I think that anyone should be allowed to review, and that the bug is in the code.

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Tue, Mar 10, 2009 at 02:34:30AM -0000, Jonathan Lange wrote:
> I think that anyone should be allowed to review, and that the bug is in
> the code.

+1. It might make sense to indicate whether a user is a member of the
default review team, but anyone should be allowed to do at least an
"unofficial" review. That way you can encourage people to try to review
branches, without giving them too much authority to begin with. The
barrier to review should be low, so that it's easier to find new
reviewers.

Aaron Bentley (abentley)
Changed in launchpad-code:
assignee: nobody → Aaron Bentley (abentley)
milestone: none → 2.2.6
status: Triaged → In Progress
Aaron Bentley (abentley)
Changed in launchpad-code:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.