Bug watches can't be removed

Bug #3140 reported by Sebastien Bacher
76
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Björn Tillenius

Bug Description

Bug watches can be added to a bug report, and they can be edited once added; but there is no way of removing an accidentally-added watch.

(See also bug 4594, about preventing duplicate watches.)

Now that bug watches are tied one-to-one to the software they're watching, this can be fixed by giving the page for editing a bug watch a menu for "Status" -- but instead of listing all the usual statuses as it would for software that uses Malone, it can have only two, "Automatic" and "Not a Bug Here" (or similar wording).

Brad Bollenbach (bradb)
Changed in malone:
assignee: nobody → bradb
status: New → Accepted
Revision history for this message
Paul Sladen (sladen) wrote :

...I was just going to report this one! I managed to create *duplicate* watches to the same remote bug:

  https://launchpad.net/distros/ubuntu/+source/xserver-xorg-driver-i810/+bug/28326

which it didn't pick up on either! :-)

description: updated
description: updated
Changed in malone:
assignee: bradb → bjornt
status: Confirmed → In Progress
Revision history for this message
Matt Zimmerman (mdz) wrote :

This bug has been marked "In Progress" for two months; is work in fact in progress?

Revision history for this message
Björn Tillenius (bjornt) wrote :

A fix for this bug was in progress, I even had a branch up for review, but then it was decided that the problem made this bug critical should be solved in another way. In the next rollout it will be possible to unlink bug watches and edit bugtasks manually in order to reject them.

Changed in malone:
status: In Progress → Confirmed
Revision history for this message
Christian Reis (kiko) wrote :

We should still allow marking watches obsolete/dead or deleting them, because not doing so makes us unable to clean up old bugs.

Changed in malone:
importance: Medium → High
Revision history for this message
Björn Tillenius (bjornt) wrote :

Matthew, the suggested UI in the description doesn't work, since bug watches don't have to be associated to a specific bugtask. Could you add suggest an UI that works even for free-standing bug watches?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I could, but it would be nasty. Instead, I suggest first requiring bug watches to be associated with a specific bugtask, *then* fixing this bug. :-)

Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 3140] Re: Bug watches can't be removed

On Wed, Oct 18, 2006 at 08:00:13AM -0000, Matthew Paul Thomas wrote:
> I could, but it would be nasty. Instead, I suggest first requiring bug
> watches to be associated with a specific bugtask, *then* fixing this
> bug. :-)

I agree with this in principle, but it requires that every distribution and
product be registered in Launchpad first, and that is not very practical for
us.

--
 - mdz

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Wed, Oct 18, 2006 at 08:19:17AM -0000, Matt Zimmerman wrote:
> On Wed, Oct 18, 2006 at 08:00:13AM -0000, Matthew Paul Thomas wrote:
> > I could, but it would be nasty. Instead, I suggest first requiring bug
> > watches to be associated with a specific bugtask, *then* fixing this
> > bug. :-)
>
> I agree with this in principle, but it requires that every distribution and
> product be registered in Launchpad first, and that is not very practical for
> us.

Matt (mdz) has a good point here. I think it's better first to fix this
bug, then think about how we can require bug watches to be associated
with a specific bugtask. I don't think the bug watch edit page is
visited that frequently, I'm sure we can get away with doing something
nasty there :)

Having the possibility to delete bug watches is better than not to have
it at all, even if the UI isn't ideal. Matthew, if you don't propose any
better solution, I might just add a "Delete this bug watch" button to
the bug watch edit page ;)

Revision history for this message
Björn Tillenius (bjornt) wrote :

I'll add a delete button to the bug watch edit page.

Changed in malone:
status: Confirmed → In Progress
Revision history for this message
Björn Tillenius (bjornt) wrote :

A fix is in the review queue.

Revision history for this message
Björn Tillenius (bjornt) wrote :

Fixed in RF 4412.

Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

just curious, what is "RF 4412"? a commit number?

Revision history for this message
Matt Zimmerman (mdz) wrote :

On Wed, Jan 17, 2007 at 05:42:04PM -0000, Sebastien Bacher wrote:
> just curious, what is "RF 4412"? a commit number?

It's a revision number on Launchpad mainline.

--
 - mdz

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Wed, Jan 17, 2007 at 05:42:04PM -0000, Sebastien Bacher wrote:
> just curious, what is "RF 4412"? a commit number?

Yes. It's short for revision 4412 in RocketFuel, which is the main
development branch.

Revision history for this message
Christian Reis (kiko) wrote :

This is available on edge, but it doesn't work yet because of a permissions issue in the database.

Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.