bzr add should optionally warn/fail if explicitly named files are ignored

Bug #308403 reported by Martin Pool
4
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Wishlist
Unassigned

Bug Description

If bzr add is explicitly given the name of an ignored file, it will give a warning but add it anyhow. It should arguably refuse to add them, with an option to override this.

I can't think of a good case where you would commonly want to add them anyhow.

Previously filed as "How to avoid that people commit .OTHER/.BASE/.THIS/.moved files?"

Martin Pool (mbp)
Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Do you mean an "If bzr add is explicitly given the name of an *explicitly* ignored file" or do you mean including files ignored by a pattern as well? For the latter, it is useful to be able to add exceptions to the general rule anyhow.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 308403] [NEW] bzr add should optionally fail if explicitly named files are ignored

On Tue, 2008-12-16 at 02:32 +0000, Martin Pool wrote:
> Public bug reported:
>
> If bzr add is explicitly given the name of an ignored file, it will give
> a warning but add it anyhow. It should arguably refuse to add them,
> with an option to override this.
>
> I can't think of a good case where you would commonly want to add them
> anyhow.

Uh? Could you expand on this argument you reference above, I know I'm
extremely happy with the way add treats ignored files at the moment -
its /never/ done the wrong thing for me.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Martin Pool (mbp)
description: updated
Changed in bzr:
assignee: nobody → bzr-qa (bzr-qa)
Revision history for this message
Robert Collins (lifeless) wrote : Re: bzr add should optionally fail if explicitly named files are ignored

Rhett, the QA team is responsible for assessing bugs and ensuring enough data is available to developers to fix them, not for actually fixing them (though QA folk can and do do development work as well).

Changed in bzr:
assignee: bzr-qa (bzr-qa) → nobody
Revision history for this message
Martin Pool (mbp) wrote :

I actually like the current behaviour, but I think Guilhem (if that's who originally mentioned it) does have a fair point that some people may be confused by doing an add with a wildcard that overlaps an ignore pattern. Perhaps we can just make it more obvious what they've done and how to get out, because a "save me flag" is not likely to be turned on by the users who need it.

Changed in bzr:
importance: Medium → Wishlist
Martin Pool (mbp)
summary: - bzr add should optionally fail if explicitly named files are ignored
+ bzr add should optionally warn/fail if explicitly named files are
+ ignored
Martin Pool (mbp)
tags: added: add ignore
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.