Control panel Network/Wireless error

(in sugar 0.82.0-1ubuntu3 on intrepid)

Short-term solution (until it is fixed upstream):

Remove "Radio" from s-c-p.

Debdiff attached.

Hi Luke,

Please provide a debdiff, rather than a .diff.gz. The latter is just for
when requesting a sponsor for a new upstream version.

Also, "Fix a string" isn't very informative. Please split that change
in to its own bullet point and expand on what you are doing and
why.

Thanks,

James

Luke, also please put the patch for src/controlpanel/view/network.py into a CDBS patch in debian/patches, ideally two patches as you're fixing two issues.

James, I've generated a debdiff for Luke's patch.

Hi,

The patched package fails to show the Control panel, due to the error below.

Thanks,

James

IndentationError: unexpected indent (network.py, line 166)
---------------------------------------------------------------------------
IndentationError Traceback (most recent call last)

/usr/share/sugar/shell/view/home/favoritesview.pyc in __controlpanel_activate_cb(self=<_MyIcon object at 0x930a20c (CanvasIcon at 0x954aad8)>, menuitem=<MenuItem object at 0x9632acc (GtkImageMenuItem at 0x9607608)>)
    445
    446 def __controlpanel_activate_cb(self, menuitem):
--> 447 panel = ControlPanel()
    448 panel.set_transient_for(self.get_toplevel())
    449 panel.show()

/usr/share/sugar/shell/controlpanel/gui.pyc in __init__(self=<ControlPanel object at 0x98f13c4 (SugarControlPanel at 0x967e050)>)
     73 self.connect("realize", self.__realize_cb)
     74
---> 75 self._options = self._get_options()
     76 self._current_option = None
     77 self._setup_main()

/usr/share/sugar/shell/controlpanel/gui.pyc in _get_options(self=<ControlPanel object at 0x98f13c4 (SugarControlPanel at 0x967e050)>)
    217 tmp = os.path.splitext(name)[0]
    218 mod = __import__('.'.join(subpath) + '.' + tmp, globals(),
--> 219 locals(), [tmp])
    220 view_class_str = getattr(mod, 'CLASS', None)
    221 if view_class_str:

IndentationError: unexpected indent (network.py, line 166)

Luke, please test your patches...

James, updated debdiff attached, tested with my PPA.

Hi,

The cancel button on the network settings does not work with this
patch:

---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)

/usr/share/sugar/shell/controlpanel/gui.pyc in __cancel_clicked_cb(self=<ControlPanel object at 0xa86eedc (SugarControlPanel at 0xa7f2ef0)>, widget=<SectionToolbar object at 0xa88416c (SectionToolbar at 0xaa66aa0)>)
    256
    257 def __cancel_clicked_cb(self, widget):
--> 258 self._section_view.undo()
    259 self._options[self._current_option]['alerts'] = []
    260 self._show_main_view()

/usr/share/sugar/shell/controlpanel/view/network.pyc in undo(self=<Network object at 0xab5d234 (SugarSectionView at 0xa8becc0)>)
    169
    170 def undo(self):
--> 171 self._button.disconnect(self._radio_change_handler)
    172 self._entry.disconnect(self._jabber_change_handler)
    173 self._model.undo()

AttributeError: 'Network' object has no attribute '_button'

Thanks,

James

I have posted this bug as invalid.

There has been significant re-factoring of the upstream code and reworking of the debian and ubuntu packaging in the last year. As such, we need to focus our very limited resource into making the new version deployable.

david