Please consider syncing xapian-core 1.0.7-4 (main) from Debian unstable (main)

Bug #282961 reported by Olly Betts
4
Affects Status Importance Assigned to Milestone
xapian-core (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

I've recently uploaded xapian-core 1.0.7-4 to Debian unstable and it's been
accepted for lenny. It adds one small safe patch over 1.0.7-3 which intrepid
currently has, and I felt I should highlight it for consideration for intrepid too,
even at this late stage.

In a nutshell, the issue is that excess precision causes a<b and b>a to
both be true, and the C++ STL nth_element() algorithm segfaults. The
gory details are documented in a comment in the attached patch.

The patch is take from upstream SVN and is very simple - just
store intermediate results in volatile
double - and it is only enabled for x86 (and m68k, but that's irrelevant
for Ubuntu). This piece of code is also only used by the affected feature.
So I believe the fix to be very safe. It also passes the upstream test suite
(including a regression test added for this bug).

The feature affected is the "elite set" query operator, used to pick the
"best N" terms from a larger set, and the bug was noticed in real world use.

I've attempted to check the source of
all the packages which use xapian-core directly or via bindings and
haven't found any uses in packages in Debian unstable. I've not
checked if there are any additional packages in Ubuntu intrepid which
might use this feature as I couldn't figure out how to check reverse
dependencies without actually installing intrepid. So there might be such
uses, and users building unpackaged code or developing their own code
could use this feature.

I've attached the patch which is the only change between 1.0.7-3 and 1.0.7-4
(apart from debian/changelog). The comment in the patch goes into a bit more
detail about the issue.

Revision history for this message
Olly Betts (ojwb) wrote :
Revision history for this message
Daniel Holbach (dholbach) wrote : ACK of sync request

ACKed.

Revision history for this message
Sebastien Bacher (seb128) wrote :

[Updating] xapian-core (1.0.7-3 [Ubuntu] < 1.0.7-4 [Debian])
 * Trying to add xapian-core...
  - <xapian-core_1.0.7-4.dsc: downloading from http://ftp.debian.org/debian/>
  - <xapian-core_1.0.7.orig.tar.gz: already in distro - downloading from librarian>
  - <xapian-core_1.0.7-4.diff.gz: downloading from http://ftp.debian.org/debian/>
I: xapian-core [main] -> libxapian15_1.0.7-3 [main].
I: xapian-core [main] -> libxapian-dev_1.0.7-3 [main].
I: xapian-core [main] -> xapian-tools_1.0.7-3 [main].
I: xapian-core [main] -> xapian-doc_1.0.7-3 [main].
I: xapian-core [main] -> xapian-examples_1.0.7-3 [main].

Changed in xapian-core:
importance: Undecided → Wishlist
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.